mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: shuahkh@osg.samsung.com, <linux-kernel@vger.kernel.org>,
	davej@codemonkey.org.uk, namhyung@kernel.org
Subject: Re: [PATCH] ftracetest: Cope properly with stack tracer not being enabled
Date: Mon, 30 Mar 2015 17:36:33 -0400	[thread overview]
Message-ID: <20150330173633.64c53cb9@gandalf.local.home> (raw)
In-Reply-To: <1427692900-11191-1-git-send-email-mpe@ellerman.id.au>

On Mon, 30 Mar 2015 16:21:40 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:

> If the stack tracer (CONFIG_STACK_TRACER) is disabled, the
> fgraph-filter-stack test blows chunks:
> 
>   [8] ftrace - function graph filters with stack tracer	[FAIL]
>   + reset_tracer
>   + echo nop
>   ./ftracetest: 19: /home/michael/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc:
>   	cannot create /proc/sys/kernel/stack_tracer_enabled: Directory nonexistent
> 
> Fix it by checking if the proc file exists before echoing to it. With
> the patch applied it fails correctly with:
> 
>   [8] ftrace - function graph filters with stack tracer	[UNSUPPORTED]
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

  reply	other threads:[~2015-03-30 21:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30  5:21 Michael Ellerman
2015-03-30 21:36 ` Steven Rostedt [this message]
2015-03-31 16:17   ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150330173633.64c53cb9@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=namhyung@kernel.org \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®