From: Lee Jones <lee.jones@linaro.org>
To: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
Cc: linux-kernel@vger.kernel.org,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Carlo Caione <carlo@caione.org>,
Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: Re: [PATCH v1 1/2] mfd/axp20x: add support for extcon cell
Date: Thu, 2 Apr 2015 08:13:53 +0100 [thread overview]
Message-ID: <20150402071353.GX9447@x1> (raw)
In-Reply-To: <1427984131-22899-2-git-send-email-ramakrishna.pallala@intel.com>
On Thu, 02 Apr 2015, Ramakrishna Pallala wrote:
> This patch adds the mfd cell info for axp288 extcon device.
>
> Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
> ---
> drivers/mfd/axp20x.c | 28 ++++++++++++++++++++++++++++
> include/linux/mfd/axp20x.h | 5 +++++
> 2 files changed, 33 insertions(+)
[...]
> diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> index dfabd6d..4ed8071 100644
> --- a/include/linux/mfd/axp20x.h
> +++ b/include/linux/mfd/axp20x.h
> @@ -275,4 +275,9 @@ struct axp20x_fg_pdata {
> int thermistor_curve[MAX_THERM_CURVE_SIZE][2];
> };
>
> +struct axp288_extcon_pdata {
> + /* GPIO pin control to switch D+/D- lines b/w PMIC and SOC */
> + struct gpio_desc *gpio_mux_cntl;
> +};
This chunk of code is unrelated to this patch.
... and does it need to be in a struct of its own?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-04-02 7:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 14:15 [PATCH v1 0/2] Add extcon support for AXP288 PMIC Ramakrishna Pallala
2015-04-02 14:15 ` [PATCH v1 1/2] mfd/axp20x: add support for extcon cell Ramakrishna Pallala
2015-04-02 7:13 ` Lee Jones [this message]
2015-04-02 8:01 ` Pallala, Ramakrishna
2015-04-02 10:54 ` Lee Jones
2015-04-02 10:56 ` Pallala, Ramakrishna
2015-04-02 14:15 ` [PATCH v1 2/2] extcon-axp288: Add axp288 extcon driver support Ramakrishna Pallala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402071353.GX9447@x1 \
--to=lee.jones@linaro.org \
--cc=carlo@caione.org \
--cc=cw00.choi@samsung.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=ramakrishna.pallala@intel.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®