Re: [PATCH v1 1/2] mfd/axp20x: add support for extcon cell

[Lee Jones <lee.jones@linaro.org>]

On Thu, 02 Apr 2015, Pallala, Ramakrishna wrote:

> Hi,
> 
> > > diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> > > index dfabd6d..4ed8071 100644
> > > --- a/include/linux/mfd/axp20x.h
> > > +++ b/include/linux/mfd/axp20x.h
> > > @@ -275,4 +275,9 @@ struct axp20x_fg_pdata {
> > >  	int thermistor_curve[MAX_THERM_CURVE_SIZE][2];
> > >  };
> > >
> > > +struct axp288_extcon_pdata {
> > > +	/* GPIO pin control to switch D+/D- lines b/w PMIC and SOC */
> > > +	struct gpio_desc *gpio_mux_cntl;
> > > +};
> > 
> > This chunk of code is unrelated to this patch.
> As it's axp20x.h file change I added it here...if you don’t feel logical to have it in the patch I can move this to patch 2/2.

You should add it to the patch that first uses it.

> > ... and does it need to be in a struct of its own?
> Yes, I am planning to add another gpio control for VBUS boost.

Okay, thanks for clarifying.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog