mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Miroslav Benes <mbenes@suse.cz>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
	linux-kernel@vger.kernel.org, x86@kernel.org, jkosina@suse.cz
Subject: Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops->func even for dynamic fops
Date: Fri, 3 Apr 2015 09:26:13 -0400	[thread overview]
Message-ID: <20150403092613.092da54e@grimm.local.home> (raw)
In-Reply-To: <alpine.LNX.2.00.1504031053110.19873@pobox.suse.cz>

On Fri, 3 Apr 2015 11:29:04 +0200 (CEST)
Miroslav Benes <mbenes@suse.cz> wrote:

> Yes, this works but there is a slight difference to the previous behaviour 
> which I tried to preserve in my patch. ftrace_ops_get_func in your patch 
> does not check FTRACE_FORCE_LIST_FUNC. I do not know if that is a real 
> problem. Anyway your approach looks much better and dynamic trampolines 
> are now used for live patches. So in this context you can add

Hmm, I'll have to take a deeper look at that. Thanks for noticing. But
that will have to wait till Monday, as I have off today ;-)

> 
> Tested-by: Miroslav Benes <mbenes@suse.cz>
> 

Thanks for testing.

-- Steve



      reply	other threads:[~2015-04-03 13:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 14:56 Miroslav Benes
2015-03-05 15:56 ` Miroslav Benes
2015-03-05 16:22   ` Steven Rostedt
2015-03-05 16:26     ` Miroslav Benes
2015-04-02 11:11     ` Miroslav Benes
2015-04-02 20:12       ` Steven Rostedt
2015-04-03  9:29         ` Miroslav Benes
2015-04-03 13:26           ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150403092613.092da54e@grimm.local.home \
    --to=rostedt@goodmis.org \
    --cc=hpa@zytor.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®