mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	linux-kernel@vger.kernel.org, namhyung@kernel.org
Subject: Re: [PATCH 2/2] perf tools: Add options 'get', 'set' and 'unset' to 'perf-config'.
Date: Tue, 7 Apr 2015 20:06:23 +0200	[thread overview]
Message-ID: <20150407180623.GB25980@krava.redhat.com> (raw)
In-Reply-To: <1428169288-8482-2-git-send-email-treeze.taeung@gmail.com>

On Sun, Apr 05, 2015 at 02:41:28AM +0900, Taeung Song wrote:
> Add 'get' option that can show value of a specific config variable
> and 'set' and 'unset' option that can create or replace a config variable.

vould you please update the changelog with the new syntax examples?
also Documentation/perf-config.txt wasn't updated

anyway..  any chance we could use syntax here that would follow
the sysctl style?

       sysctl [options] [variable[=value]] [...]
       sysctl -p [file or regexp] [...]

# display current config
perf config

# display current config plus all keys with default values
perf config -a

# display key value:
perf config report.queue

# set key value:
perf config report.queue=100M

# remove key (not in sysctl)
perf config -r report.queue

jirka

  reply	other threads:[~2015-04-07 18:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-04 17:41 [PATCH 1/2] perf tools: Add 'perf-config' command Taeung Song
2015-04-04 17:41 ` [PATCH 2/2] perf tools: Add options 'get', 'set' and 'unset' to 'perf-config' Taeung Song
2015-04-07 18:06   ` Jiri Olsa [this message]
2015-04-07 17:57 ` [PATCH 1/2] perf tools: Add 'perf-config' command Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150407180623.GB25980@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=treeze.taeung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®