From: Mark Brown <broonie@kernel.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: kconfig: make max8973 driver to depend on GPIOLIB
Date: Wed, 8 Apr 2015 17:43:23 +0100 [thread overview]
Message-ID: <20150408164323.GA6023@sirena.org.uk> (raw)
In-Reply-To: <1428500227-3379-1-git-send-email-ldewangan@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
On Wed, Apr 08, 2015 at 07:07:07PM +0530, Laxman Dewangan wrote:
> MAX8973 regulator driver uses the GPIO APIs for accessing the
> control signal connected to its pin from host processor.
>
> Make this driver depends on GPIOLIB.
The GPIO usage in the driver appears to be optional, it handles the GPIO
not being controllable. This suggests to me that the gpiolib dependency
shouldn't be required and that it would be better to fix this by
ensuring that all the gpiolib functions being used have appropriate
stubs. Which ones are causing problems?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-08 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 13:37 Laxman Dewangan
2015-04-08 16:43 ` Mark Brown [this message]
2015-04-09 10:01 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408164323.GA6023@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®