From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Robin Karlsson <s.r.karlsson@gmail.com>
Cc: greg@kroah.com, teddy.wang@siliconmotion.com,
sudip@vectorindia.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: sm750fb: fix brace coding style issues
Date: Fri, 10 Apr 2015 11:17:47 +0530 [thread overview]
Message-ID: <20150410054747.GB3561@sudip-PC> (raw)
In-Reply-To: <1428617536-9324-1-git-send-email-s.r.karlsson@gmail.com>
On Fri, Apr 10, 2015 at 12:12:15AM +0200, Robin Karlsson wrote:
> This is a patch to sm750fb that fixes brace coding style errors and warnings found by checkpatch.pl
Try to limit this commit message to 72 char.
You should usually use scripts/get_maintainer.pl to see where to send
the mail.
>
> Signed-off-by: Robin Karlsson <s.r.karlsson@gmail.com>
> ---
<snip>
> @@ -217,19 +214,17 @@ void hw_cursor_setData2(struct lynx_cursor * cursor,
> else
> opr = mask & color;
>
> - for(j=0;j<8;j++)
> - {
> + for(j=0;j<8;j++) {
>
> - if(opr & (0x80 >> j))
> - { //use fg color,id = 2
> + if(opr & (0x80 >> j)) { //use fg color,id = 2
this is introducing new checkpatch error.
Error: trailing statements should be on next line
regards
sudip
> data |= 2 << (j*2);
prev parent reply other threads:[~2015-04-10 5:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 22:12 Robin Karlsson
2015-04-09 22:12 ` [PATCH 2/2] Staging: sm750fb: Fix spelling error in TODO Robin Karlsson
2015-04-10 5:47 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150410054747.GB3561@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.r.karlsson@gmail.com \
--cc=sudip@vectorindia.org \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®