* [PATCH v2] regulator: max8660: Handle empty regulator data
@ 2015-04-10 13:23 Markus Pargmann
2015-04-10 17:18 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Markus Pargmann @ 2015-04-10 13:23 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, Wolfram Sang, kernel, linux-kernel, Markus Pargmann
It is not necessary to have regulator init data for a regulator. This
patch removes the necessity of this data and handles a NULL pointer
properly.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
drivers/regulator/max8660.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/max8660.c b/drivers/regulator/max8660.c
index 7eee2ca18541..1d38d5d1d7b0 100644
--- a/drivers/regulator/max8660.c
+++ b/drivers/regulator/max8660.c
@@ -443,9 +443,9 @@ static int max8660_probe(struct i2c_client *client,
for (i = 0; i < pdata->num_subdevs; i++) {
if (!pdata->subdevs[i].platform_data)
- return ret;
-
- boot_on = pdata->subdevs[i].platform_data->constraints.boot_on;
+ boot_on = false;
+ else
+ boot_on = pdata->subdevs[i].platform_data->constraints.boot_on;
switch (pdata->subdevs[i].id) {
case MAX8660_V3:
--
2.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] regulator: max8660: Handle empty regulator data
2015-04-10 13:23 [PATCH v2] regulator: max8660: Handle empty regulator data Markus Pargmann
@ 2015-04-10 17:18 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2015-04-10 17:18 UTC (permalink / raw)
To: Markus Pargmann; +Cc: Liam Girdwood, Wolfram Sang, kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
On Fri, Apr 10, 2015 at 03:23:42PM +0200, Markus Pargmann wrote:
> It is not necessary to have regulator init data for a regulator. This
> patch removes the necessity of this data and handles a NULL pointer
> properly.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-10 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-10 13:23 [PATCH v2] regulator: max8660: Handle empty regulator data Markus Pargmann
2015-04-10 17:18 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®