From: Mark Brown <broonie@kernel.org>
To: Pelle Nilsson <per.nilsson@xelmo.com>
Cc: ezequiel@vanguardiasur.com.ar, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, nios2-dev@lists.rocketboards.org
Subject: Re: [PATCH v2] spi: bitbang: Make setup_transfer() callback optional
Date: Sat, 18 Apr 2015 12:00:55 +0100 [thread overview]
Message-ID: <20150418110055.GC26185@sirena.org.uk> (raw)
In-Reply-To: <1429018817-18117-1-git-send-email-per.nilsson@xelmo.com>
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
On Tue, Apr 14, 2015 at 03:40:17PM +0200, Pelle Nilsson wrote:
> Some controller drivers have no need of this callback (spi-altera even
> causes a NULL pointer dereference because it doesn't register the callback,
> falsely assuming that it is already optional).
I've applied this but really for something like this the commit message
should be explaining *why* it's reasonable for the callback to be
omitted.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-18 11:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 15:03 [PATCH 0/1] Fix NULL pointer dereference Pelle Nilsson
2015-04-09 15:03 ` [PATCH 1/1] spi: altera: Add empty implementation of setup_transfer callback Pelle Nilsson
2015-04-09 15:40 ` Mark Brown
2015-04-09 15:50 ` Pelle Nilsson
2015-04-09 16:10 ` Mark Brown
2015-04-13 9:45 ` Pelle Nilsson
2015-04-13 10:08 ` [PATCH] spi: bitbang: Make setup_transfer callback optional Pelle Nilsson
2015-04-14 0:22 ` [Nios2-dev] " Ezequiel Garcia
2015-04-14 13:40 ` [PATCH v2] spi: bitbang: Make setup_transfer() " Pelle Nilsson
2015-04-14 15:36 ` Ezequiel Garcia
2015-04-18 11:00 ` Mark Brown [this message]
2015-04-09 15:26 ` [PATCH 0/1] Fix NULL pointer dereference Mark Brown
2015-04-09 15:54 ` [PATCH v2] spi: altera: Add empty implementation of setup_transfer callback Pelle Nilsson
2015-04-09 16:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150418110055.GC26185@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nios2-dev@lists.rocketboards.org \
--cc=per.nilsson@xelmo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome