From: Mark Brown <broonie@kernel.org>
To: Kevin Cernekee <cernekee@chromium.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
lgirdwood@gmail.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org,
Andrew Bresticker <abrestic@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dgreid@chromium.org, Olof Johansson <olofj@chromium.org>
Subject: Re: [alsa-devel] [PATCH 2/3] ASoC: tas571x: New driver for TI TAS571x power amplifiers
Date: Mon, 20 Apr 2015 22:14:26 +0100 [thread overview]
Message-ID: <20150420211426.GN14892@sirena.org.uk> (raw)
In-Reply-To: <CAJzqFtbxKJirP9=hzHzQ=6KM=OayPmEDhJfkSx25DH4fu-gVgg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 910 bytes --]
On Mon, Apr 20, 2015 at 01:56:46PM -0700, Kevin Cernekee wrote:
> On Thu, Apr 16, 2015 at 5:57 AM, Lars-Peter Clausen <lars@metafoo.de> wrote:
> > On 04/15/2015 11:42 PM, Kevin Cernekee wrote:
> > If you want to make the clock optional use
> > if (PTR_ERR(priv->mclk) == -ENOENT)
> > return PTR_ERR(priv->mclk);
> > This makes sure that the case where the clock is specified, but there is a
> > error with the specification (e.g. incorrect DT cells) is handled properly.
> Did you mean:
> > if (PTR_ERR(priv->mclk) != -ENOENT)
> > return PTR_ERR(priv->mclk);
> I don't see this in other codec drivers, but I do see the explicit
> EPROBE_DEFER check in max98090, max98095, pcm512x, and wm8960.
That's the most correct way of writing a check for an optional clock,
best practice on this stuff is evolving over time (as is standardization
in the clock API).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-20 21:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 21:42 [PATCH 1/3] ASoC: tas571x: Add DT binding document Kevin Cernekee
2015-04-15 21:42 ` [PATCH 2/3] ASoC: tas571x: New driver for TI TAS571x power amplifiers Kevin Cernekee
2015-04-16 12:57 ` [alsa-devel] " Lars-Peter Clausen
2015-04-18 11:39 ` Mark Brown
2015-04-20 20:56 ` Kevin Cernekee
2015-04-20 21:14 ` Mark Brown [this message]
2015-04-18 11:36 ` Mark Brown
2015-04-18 16:16 ` Kevin Cernekee
2015-04-18 17:11 ` Mark Brown
2015-04-18 20:07 ` Kevin Cernekee
2015-04-20 12:21 ` Mark Brown
2015-04-20 15:12 ` Kevin Cernekee
2015-04-20 16:05 ` Andrew Bresticker
2015-04-20 20:14 ` Mark Brown
2015-04-24 0:47 ` Kevin Cernekee
2015-04-24 9:28 ` Mark Brown
2015-04-24 13:52 ` Kevin Cernekee
2015-04-24 16:50 ` Mark Brown
2015-04-15 21:42 ` [PATCH 3/3] MAINTAINERS: Add entry for tas571x ASoC codec driver Kevin Cernekee
2015-04-18 11:16 ` [PATCH 1/3] ASoC: tas571x: Add DT binding document Mark Brown
2015-04-20 21:16 ` Kevin Cernekee
2015-04-20 21:18 ` Kevin Cernekee
2015-04-20 22:03 ` Mark Brown
2015-04-20 22:48 ` Kevin Cernekee
2015-04-21 16:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420211426.GN14892@sirena.org.uk \
--to=broonie@kernel.org \
--cc=abrestic@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=cernekee@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dgreid@chromium.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olofj@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®