Re: [PATCH 1/3] ASoC: tas571x: Add DT binding document

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

On Mon, Apr 20, 2015 at 03:48:19PM -0700, Kevin Cernekee wrote:

> I don't understand the statement: "those are three separate supplies
> that are typically tied together."  AVDD/DVDD are 3.3v fixed but PVDD
> is 8V minimum (5711) or 4.5V minimum (5717/5719).  So AVDD/DVDD can
> never be driven by the same regulator output as PVDD.  Perhaps you
> were thinking of HPVDD/AVDD/DVDD on 5717/5719?

Yes, all the supplies.  I'd misremembered which ones you were saying
were tied together on your board.

> The simplified application diagram on page 2 does show that AVDD/DVDD
> are typically tied together, and that PVDD_* are also typically tied
> together.  But as you pointed out, there may be situations where that
> isn't the case, so that leaves us with up to 6 separate supplies on
> 5711, or 5 on 5717/5719.  The typical case is probably closer to 2 or
> 3, though.

To repeat, the typical case is *not* *relevant*.  All that matters is
the set of supplies the device has.

> > Have the driver accurately reflect the hardware, request one regulator
> > per supply.

> So, request one regulator per VDD pin?  Or group all of PVDD_* into a
> single regulator?

Please group them into supplies as documented in the datasheet.  If they
are documented as distinct things they should be distinct things, if
they are just the same supply coming in through multiple pins for power
reasons they should be one supply.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]