From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCHv3] perf/x86/intel: Add cpu_(prepare|starting|dying) for core_pmu
Date: Tue, 21 Apr 2015 23:00:16 +0200 [thread overview]
Message-ID: <20150421210016.GC2898@worktop.Skamania.guest> (raw)
In-Reply-To: <20150421152623.GC13169@krava.redhat.com>
On Tue, Apr 21, 2015 at 05:26:23PM +0200, Jiri Olsa wrote:
> The core_pmu does not define cpu_* callbacks, which handles
> allocation of 'struct cpu_hw_events::shared_regs' data,
> initialization of debug store and PMU_FL_EXCL_CNTRS counters.
>
> While this probably won't happen on bare metal, virtual CPU can
> define x86_pmu.extra_regs together with PMU version 1 and thus
> be using core_pmu -> using shared_regs data without it being
> allocated. That could could leave to following panic:
>
> BUG: unable to handle kernel NULL pointer dereference at (null)
> IP: [<ffffffff8152cd4f>] _spin_lock_irqsave+0x1f/0x40
>
> SNIP
>
> [<ffffffff81024bd9>] __intel_shared_reg_get_constraints+0x69/0x1e0
> [<ffffffff81024deb>] intel_get_event_constraints+0x9b/0x180
> [<ffffffff8101e815>] x86_schedule_events+0x75/0x1d0
> [<ffffffff810586dc>] ? check_preempt_curr+0x7c/0x90
> [<ffffffff810649fe>] ? try_to_wake_up+0x24e/0x3e0
> [<ffffffff81064ba2>] ? default_wake_function+0x12/0x20
> [<ffffffff8109eb16>] ? autoremove_wake_function+0x16/0x40
> [<ffffffff810577e9>] ? __wake_up_common+0x59/0x90
> [<ffffffff811a9517>] ? __d_lookup+0xa7/0x150
> [<ffffffff8119db5f>] ? do_lookup+0x9f/0x230
> [<ffffffff811a993a>] ? dput+0x9a/0x150
> [<ffffffff8119c8f5>] ? path_to_nameidata+0x25/0x60
> [<ffffffff8119e90a>] ? __link_path_walk+0x7da/0x1000
> [<ffffffff8101d8f9>] ? x86_pmu_add+0xb9/0x170
> [<ffffffff8101d7a7>] x86_pmu_commit_txn+0x67/0xc0
> [<ffffffff811b07b0>] ? mntput_no_expire+0x30/0x110
> [<ffffffff8119c731>] ? path_put+0x31/0x40
> [<ffffffff8107c297>] ? current_fs_time+0x27/0x30
> [<ffffffff8117d170>] ? mem_cgroup_get_reclaim_stat_from_page+0x20/0x70
> [<ffffffff8111b7aa>] group_sched_in+0x13a/0x170
> [<ffffffff81014a29>] ? sched_clock+0x9/0x10
> [<ffffffff8111bac8>] ctx_sched_in+0x2e8/0x330
> [<ffffffff8111bb7b>] perf_event_sched_in+0x6b/0xb0
> [<ffffffff8111bc36>] perf_event_context_sched_in+0x76/0xc0
> [<ffffffff8111eb3b>] perf_event_comm+0x1bb/0x2e0
> [<ffffffff81195ee9>] set_task_comm+0x69/0x80
> [<ffffffff81195fe1>] setup_new_exec+0xe1/0x2e0
> [<ffffffff811ea68e>] load_elf_binary+0x3ce/0x1ab0
>
> Adding cpu_(prepare|starting|dying) for core_pmu to have shared_regs
> data allocated for core_pmu. AFAICS there's no harm to initialize
> debug store and PMU_FL_EXCL_CNTRS either for core_pmu.
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
next prev parent reply other threads:[~2015-04-21 21:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 8:54 [PATCH] " Jiri Olsa
2015-04-21 10:52 ` Ingo Molnar
2015-04-21 15:14 ` [PATCHv2] " Jiri Olsa
2015-04-21 15:12 ` [PATCH] " Peter Zijlstra
2015-04-21 15:18 ` Jiri Olsa
2015-04-21 15:26 ` [PATCHv3] " Jiri Olsa
2015-04-21 21:00 ` Peter Zijlstra [this message]
2015-04-22 14:10 ` [tip:perf/urgent] perf/x86/intel: Add cpu_(prepare|starting|dying ) " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150421210016.GC2898@worktop.Skamania.guest \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®