From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf/x86/intel: Add cpu_(prepare|starting|dying) for core_pmu
Date: Tue, 21 Apr 2015 17:12:16 +0200 [thread overview]
Message-ID: <20150421151216.GD3182@worktop.meeting.verilan.com> (raw)
In-Reply-To: <1429606465-10271-1-git-send-email-jolsa@kernel.org>
On Tue, Apr 21, 2015 at 10:54:25AM +0200, Jiri Olsa wrote:
> @@ -2559,6 +2563,9 @@ static __initconst const struct x86_pmu core_pmu = {
> .guest_get_msrs = core_guest_get_msrs,
> .format_attrs = intel_arch_formats_attr,
> .events_sysfs_show = intel_event_sysfs_show,
Could you also insert a little comment here how these methods are for
'funny' 'hardware' ?
> + .cpu_prepare = intel_pmu_cpu_prepare,
> + .cpu_starting = intel_pmu_cpu_starting,
> + .cpu_dying = intel_pmu_cpu_dying,
> };
>
> struct intel_shared_regs *allocate_shared_regs(int cpu)
> --
> 1.9.3
>
next prev parent reply other threads:[~2015-04-21 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 8:54 Jiri Olsa
2015-04-21 10:52 ` Ingo Molnar
2015-04-21 15:14 ` [PATCHv2] " Jiri Olsa
2015-04-21 15:12 ` Peter Zijlstra [this message]
2015-04-21 15:18 ` [PATCH] " Jiri Olsa
2015-04-21 15:26 ` [PATCHv3] " Jiri Olsa
2015-04-21 21:00 ` Peter Zijlstra
2015-04-22 14:10 ` [tip:perf/urgent] perf/x86/intel: Add cpu_(prepare|starting|dying ) " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150421151216.GD3182@worktop.meeting.verilan.com \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome