From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Lai Jiangshan" <laijs@cn.fujitsu.com>,
"Dipankar Sarma" <dipankar@in.ibm.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Josh Triplett" <josh@joshtriplett.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Peter Zijlstra" <peterz@infradead.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"David Howells" <dhowells@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
"Darren Hart" <dvhart@linux.intel.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Oleg Nesterov" <oleg@redhat.com>
Subject: Re: [PATCH tip/core/rcu 11/12] rcu: Make RCU able to tolerate undefined CONFIG_RCU_FANOUT_LEAF
Date: Wed, 22 Apr 2015 07:30:54 -0700 [thread overview]
Message-ID: <20150422143054.GY5561@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJhHMCC7aZ_pHhZ0g176+RpzyTw5hpwEQNbM9Fp-GHGgpBgiXQ@mail.gmail.com>
On Wed, Apr 22, 2015 at 01:25:07AM -0400, Pranith Kumar wrote:
> On Tue, Apr 21, 2015 at 3:55 PM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
>
> > diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> > index 2e52502bfc95..a2f64e4fdb57 100644
> > --- a/kernel/rcu/tree_plugin.h
> > +++ b/kernel/rcu/tree_plugin.h
> > @@ -86,10 +86,10 @@ static void __init rcu_bootup_announce_oddness(void)
> > pr_info("\tAdditional per-CPU info printed with stalls.\n");
> > if (RCU_NUM_LVLS >= 4)
> > pr_info("\tFour(or more)-level hierarchy is enabled.\n");
> > - if (CONFIG_RCU_FANOUT_LEAF != 16)
> > + if (RCU_FANOUT_LEAF != 16)
>
> So if CONFIG_RCU_FANOUT_LEAF is either by default 32 or 64, this check
> against 16 for build-time adjustment is a bit misleading, no?
Indeed!
However, with the fix that puts the default back to 16, this should be
once again correct.
Thanx, Paul
next prev parent reply other threads:[~2015-04-22 14:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 19:55 [PATCH tip/core/rcu 0/12] RCU Kconfig fixes for v4.2 Paul E. McKenney
2015-04-21 19:55 ` [PATCH tip/core/rcu 01/12] rcu: Directly drive TASKS_RCU from Kconfig Paul E. McKenney
2015-04-21 19:55 ` [PATCH tip/core/rcu 02/12] rcutorture: TASKS_RCU set directly, so don't explicitly set it Paul E. McKenney
2015-04-21 19:55 ` [PATCH tip/core/rcu 03/12] rcu: Directly drive RCU_USER_QS from Kconfig Paul E. McKenney
2015-04-21 19:55 ` [PATCH tip/core/rcu 04/12] rcu: Covert CONFIG_RCU_FANOUT_EXACT to boot parameter Paul E. McKenney
2015-04-21 19:55 ` [PATCH tip/core/rcu 05/12] rcutorture: Update configuration fragments for rcutree.rcu_fanout_exact Paul E. McKenney
2015-04-22 5:08 ` Pranith Kumar
2015-04-22 14:24 ` Paul E. McKenney
2015-04-21 19:55 ` [PATCH tip/core/rcu 06/12] rcu: Enable diagnostic dump of rcu_node combining tree Paul E. McKenney
2015-04-21 19:55 ` [PATCH tip/core/rcu 07/12] rcu: Create RCU_EXPERT Kconfig and hide booleans behind it Paul E. McKenney
2015-04-21 19:55 ` [PATCH tip/core/rcu 08/12] rcutorture: Make rcutorture scripts force RCU_EXPERT Paul E. McKenney
2015-04-21 19:55 ` [PATCH tip/core/rcu 09/12] rcu: Break dependency of RCU_FANOUT_LEAF on RCU_FANOUT Paul E. McKenney
2015-04-22 5:22 ` Pranith Kumar
2015-04-22 14:30 ` Paul E. McKenney
2015-04-21 19:55 ` [PATCH tip/core/rcu 10/12] rcu: Make RCU able to tolerate undefined CONFIG_RCU_FANOUT Paul E. McKenney
2015-04-21 19:55 ` [PATCH tip/core/rcu 11/12] rcu: Make RCU able to tolerate undefined CONFIG_RCU_FANOUT_LEAF Paul E. McKenney
2015-04-22 5:25 ` Pranith Kumar
2015-04-22 14:30 ` Paul E. McKenney [this message]
2015-04-21 19:55 ` [PATCH tip/core/rcu 12/12] rcu: Make RCU able to tolerate undefined CONFIG_RCU_KTHREAD_PRIO Paul E. McKenney
2015-04-22 5:26 ` [PATCH tip/core/rcu 0/12] RCU Kconfig fixes for v4.2 Pranith Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422143054.GY5561@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome