From: Steven Rostedt <rostedt@goodmis.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: mingo@redhat.com, Dave.Martin@arm.com,
linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
Javi Merino <javi.merino@arm.com>,
"Peter Zijlstra \(Intel\)" <peterz@infradead.org>
Subject: Re: [PATCH v2] tracing: make ftrace_print_array_seq compute buf_len
Date: Wed, 29 Apr 2015 12:06:22 -0400 [thread overview]
Message-ID: <20150429120622.48c62110@gandalf.local.home> (raw)
In-Reply-To: <87mw1q2a8l.fsf@linaro.org>
On Wed, 29 Apr 2015 17:02:50 +0100
Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Steven Rostedt <rostedt@goodmis.org> writes:
>
> > On Wed, 29 Apr 2015 16:18:46 +0100
> > Alex Bennée <alex.bennee@linaro.org> wrote:
> >
> >> The only caller to this function (__print_array) was getting it wrong by
> >> passing the array length instead of buffer length. As the element size
> >> was already being passed for other reasons it seems reasonable to push
> >> the calculation of buffer length into the function.
> >>
> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >
> > Thanks, I'll add a stable tag to this too, and get it out soon.
>
> I take it you'll pick up Dave's reviewed-by?
Yep, I will.
>
> As for CC'ing stable I wouldn't worry too much as nothing in the kernel
> uses __print_array yet (unless you count the example). But it is a
> fairly trivial patch so if you as the maintainer is happy I'm happy ;-)
OK, if it's not used, then I'll just add it to this release.
Thanks,
-- Steve
next prev parent reply other threads:[~2015-04-29 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 15:18 Alex Bennée
2015-04-29 15:36 ` Steven Rostedt
2015-04-29 16:02 ` Alex Bennée
2015-04-29 16:06 ` Steven Rostedt [this message]
2015-04-29 16:12 ` Javi Merino
2015-04-29 16:26 ` Steven Rostedt
2015-04-29 15:52 ` Dave P Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429120622.48c62110@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Dave.Martin@arm.com \
--cc=alex.bennee@linaro.org \
--cc=javi.merino@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®