From: Javi Merino <javi.merino@arm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"Dave P Martin" <Dave.Martin@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Oleg Nesterov" <oleg@redhat.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: Re: [PATCH v2] tracing: make ftrace_print_array_seq compute buf_len
Date: Wed, 29 Apr 2015 17:12:21 +0100 [thread overview]
Message-ID: <20150429161221.GI3054@e104805> (raw)
In-Reply-To: <20150429120622.48c62110@gandalf.local.home>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1500 bytes --]
On Wed, Apr 29, 2015 at 05:06:22PM +0100, Steven Rostedt wrote:
> On Wed, 29 Apr 2015 17:02:50 +0100
> Alex Bennée <alex.bennee@linaro.org> wrote:
>
> >
> > Steven Rostedt <rostedt@goodmis.org> writes:
> >
> > > On Wed, 29 Apr 2015 16:18:46 +0100
> > > Alex Bennée <alex.bennee@linaro.org> wrote:
> > >
> > >> The only caller to this function (__print_array) was getting it wrong by
> > >> passing the array length instead of buffer length. As the element size
> > >> was already being passed for other reasons it seems reasonable to push
> > >> the calculation of buffer length into the function.
> > >>
> > >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > >
> > > Thanks, I'll add a stable tag to this too, and get it out soon.
> >
> > I take it you'll pick up Dave's reviewed-by?
>
> Yep, I will.
>
> >
> > As for CC'ing stable I wouldn't worry too much as nothing in the kernel
> > uses __print_array yet (unless you count the example). But it is a
> > fairly trivial patch so if you as the maintainer is happy I'm happy ;-)
>
> OK, if it's not used, then I'll just add it to this release.
Our maintainer missed the merge window (sigh) so the patches that were
going to use this will have to wait until linux v4.2. So they will be
users in the future, but there's no need for this to go to stable.
Cheers,
Javi
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2015-04-29 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 15:18 Alex Bennée
2015-04-29 15:36 ` Steven Rostedt
2015-04-29 16:02 ` Alex Bennée
2015-04-29 16:06 ` Steven Rostedt
2015-04-29 16:12 ` Javi Merino [this message]
2015-04-29 16:26 ` Steven Rostedt
2015-04-29 15:52 ` Dave P Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429161221.GI3054@e104805 \
--to=javi.merino@arm.com \
--cc=Dave.Martin@arm.com \
--cc=alex.bennee@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®