From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Felipe Balbi <balbi@ti.com>
Cc: David Cohen <david.a.cohen@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Baolu Lu <baolu.lu@linux.intel.com>,
Paul Bolle <pebolle@tiscali.nl>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 10/12] usb: dwc3: add ULPI interface support
Date: Thu, 30 Apr 2015 13:34:22 +0300 [thread overview]
Message-ID: <20150430103422.GB1372@kuha.fi.intel.com> (raw)
In-Reply-To: <20150429150450.GC7262@saruman.tx.rr.com>
Hi Felipe,
> > + case DWC3_GHWPARAMS3_HSPHY_IFC_ULPI:
> > + /* Soft reset here to sync the clocks */
> > + ret = dwc3_soft_reset(dwc);
>
> you just lost all DWC3_GUSB3PIPECTL(0) and DWC3_GUSB2PHYCFG(0)
> configurations which happened right before this switch. Essentially
> breaking anybody who needs any of those extra bits enabled even though
> they're not enabled by default.
Is this a problem we have with DWC3 cores older then 1.94? I don't
know anything about those. If it is, then I would imagine we just need
to soft reset here conditionally, only cores >= 1.94a, right?
With 1.94a and newer, DWC3_GUSB3PIPECTL(0) and DWC3_GUSB2PHYCFG(0)
keep their ctx over any kind of soft reset. And any configurations
done to them here will take affect the latest when
dwc3_core_soft_reset() is called.
Thanks,
--
heikki
next prev parent reply other threads:[~2015-04-30 10:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 13:24 [PATCHv3 00/12] usb: ulpi bus Heikki Krogerus
2015-04-28 13:24 ` [PATCHv3 01/11] usb: add bus type for USB ULPI Heikki Krogerus
2015-04-29 20:13 ` Felipe Balbi
2015-04-30 10:37 ` Heikki Krogerus
2015-04-28 13:24 ` [PATCHv3 02/11] usb: dwc3: USB2 PHY register access bits Heikki Krogerus
2015-04-28 13:24 ` [PATCHv3 03/11] usb: dwc3: ULPI or UTMI+ select Heikki Krogerus
2015-04-28 13:24 ` [PATCHv3 04/11] usb: dwc3: store driver data earlier Heikki Krogerus
2015-04-28 13:24 ` [PATCHv3 05/11] usb: dwc3: cache hwparams earlier Heikki Krogerus
2015-04-28 13:24 ` [PATCHv3 06/11] usb: dwc3: soft reset to it's own function Heikki Krogerus
2015-04-28 17:22 ` Felipe Balbi
2015-04-29 8:16 ` Heikki Krogerus
2015-04-28 13:24 ` [PATCHv3 07/11] usb: dwc3: setup phys earlier Heikki Krogerus
2015-04-28 13:24 ` [PATCHv3 08/11] usb: dwc3: add hsphy_interface property Heikki Krogerus
2015-04-28 17:13 ` Felipe Balbi
2015-04-29 8:04 ` Heikki Krogerus
2015-04-28 13:24 ` [PATCHv3 09/11] usb: dwc3: pci: add quirk for Baytrails Heikki Krogerus
2015-04-28 13:24 ` [PATCHv3 10/11] phy: helpers for USB ULPI PHY registering Heikki Krogerus
2015-04-28 13:24 ` [PATCHv3 11/11] phy: add driver for TI TUSB1210 ULPI PHY Heikki Krogerus
2015-04-28 17:17 ` [PATCHv3 00/12] usb: ulpi bus Felipe Balbi
2015-04-29 8:21 ` Heikki Krogerus
2015-04-29 8:30 ` [PATCHv3 08/12] usb: dwc3: add hsphy_interface property Heikki Krogerus
2015-04-29 15:03 ` Felipe Balbi
2015-04-30 10:33 ` Heikki Krogerus
2015-04-29 8:30 ` [PATCHv3 09/12] usb: dwc3: pci: add quirk for Baytrails Heikki Krogerus
2015-04-29 8:30 ` [PATCHv3 10/12] usb: dwc3: add ULPI interface support Heikki Krogerus
2015-04-29 15:04 ` Felipe Balbi
2015-04-30 10:34 ` Heikki Krogerus [this message]
2015-04-30 14:54 ` Felipe Balbi
2015-05-04 12:03 ` Heikki Krogerus
2015-05-05 15:02 ` Felipe Balbi
2015-04-29 8:30 ` [PATCHv3 11/12] phy: helpers for USB ULPI PHY registering Heikki Krogerus
2015-04-29 8:30 ` [PATCHv3 12/12] phy: add driver for TI TUSB1210 ULPI PHY Heikki Krogerus
-- strict thread matches above, loose matches on Subject: below --
2015-03-19 11:48 [PATCHv2 10/12] usb: dwc3: add ULPI interface support Heikki Krogerus
2015-03-20 12:20 ` [PATCHv3 " Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430103422.GB1372@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=balbi@ti.com \
--cc=baolu.lu@linux.intel.com \
--cc=david.a.cohen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome