mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v4] usb: gadget: composite: enable BESL support
@ 2015-04-30  5:32 Du, Changbin
  2015-04-30 20:53 ` gregkh
  0 siblings, 1 reply; 2+ messages in thread
From: Du, Changbin @ 2015-04-30  5:32 UTC (permalink / raw)
  To: balbi; +Cc: stable, gregkh, linux-usb, linux-kernel, Cohen, David A, Wu, Hao

>From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001
From: Felipe Balbi <balbi@ti.com>
Date: Tue, 30 Sep 2014 16:08:03 -0500
Subject: [PATCH] usb: gadget: composite: enable BESL support

commit a6615937bcd9234e6d6bb817c3701fce44d0a84d upstream.

According to USB 2.0 ECN Errata for Link Power
Management (USB2-LPM-Errata-final.pdf), BESL
must be enabled if LPM is enabled.

This helps with USB30CV TD 9.21 LPM L1
Suspend Resume Test.

Cc: <stable@vger.kernel.org> # 3.1+
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Du, Changbin <changbin.du@intel.com>
---
Hi,

This patch was introduced on v3.18. However the issue fixed already existed on
v3.1. Thank Balbi for pointing it out.

So propose to backport it over all 3.1+ stable trees as well.

Du, Changbin
---
 drivers/usb/gadget/composite.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index a8c18df..f6a51fd 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -560,7 +560,7 @@ static int bos_desc(struct usb_composite_dev *cdev)
 	usb_ext->bLength = USB_DT_USB_EXT_CAP_SIZE;
 	usb_ext->bDescriptorType = USB_DT_DEVICE_CAPABILITY;
 	usb_ext->bDevCapabilityType = USB_CAP_TYPE_EXT;
-	usb_ext->bmAttributes = cpu_to_le32(USB_LPM_SUPPORT);
+	usb_ext->bmAttributes = cpu_to_le32(USB_LPM_SUPPORT | USB_BESL_SUPPORT);
 
 	/*
 	 * The Superspeed USB Capability descriptor shall be implemented by all
-- 
1.9.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v4] usb: gadget: composite: enable BESL support
  2015-04-30  5:32 [PATCH v4] usb: gadget: composite: enable BESL support Du, Changbin
@ 2015-04-30 20:53 ` gregkh
  0 siblings, 0 replies; 2+ messages in thread
From: gregkh @ 2015-04-30 20:53 UTC (permalink / raw)
  To: Du, Changbin
  Cc: balbi, stable, linux-usb, linux-kernel, Cohen, David A, Wu, Hao

On Thu, Apr 30, 2015 at 05:32:57AM +0000, Du, Changbin wrote:
> >From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001
> From: Felipe Balbi <balbi@ti.com>
> Date: Tue, 30 Sep 2014 16:08:03 -0500
> Subject: [PATCH] usb: gadget: composite: enable BESL support
> 
> commit a6615937bcd9234e6d6bb817c3701fce44d0a84d upstream.
> 
> According to USB 2.0 ECN Errata for Link Power
> Management (USB2-LPM-Errata-final.pdf), BESL
> must be enabled if LPM is enabled.
> 
> This helps with USB30CV TD 9.21 LPM L1
> Suspend Resume Test.
> 
> Cc: <stable@vger.kernel.org> # 3.1+
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Du, Changbin <changbin.du@intel.com>
> ---
> Hi,
> 
> This patch was introduced on v3.18. However the issue fixed already existed on
> v3.1. Thank Balbi for pointing it out.
> 
> So propose to backport it over all 3.1+ stable trees as well.

All I really needed was just the git commit id, and what stable trees to
apply it to, no need to keep resending the patch...

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-30 20:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-30  5:32 [PATCH v4] usb: gadget: composite: enable BESL support Du, Changbin
2015-04-30 20:53 ` gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome