From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 07/12] mm: Pass the 4-bit protection key in via PROT_ bits to syscalls
Date: Thu, 7 May 2015 20:11:51 +0100 [thread overview]
Message-ID: <20150507201151.5658faa1@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20150507174135.FD8A0FA9@viggo.jf.intel.com>
> diff -puN include/uapi/asm-generic/mman-common.h~pkeys-11-user-abi-bits include/uapi/asm-generic/mman-common.h
> --- a/include/uapi/asm-generic/mman-common.h~pkeys-11-user-abi-bits 2015-05-07 10:31:43.367276719 -0700
> +++ b/include/uapi/asm-generic/mman-common.h 2015-05-07 10:31:43.370276855 -0700
> @@ -10,6 +10,10 @@
> #define PROT_WRITE 0x2 /* page can be written */
> #define PROT_EXEC 0x4 /* page can be executed */
> #define PROT_SEM 0x8 /* page may be used for atomic ops */
> +#define PROT_PKEY0 0x10 /* protection key value (bit 0) */
> +#define PROT_PKEY1 0x20 /* protection key value (bit 1) */
> +#define PROT_PKEY2 0x40 /* protection key value (bit 2) */
> +#define PROT_PKEY3 0x80 /* protection key value (bit 3) */
Thats leaking deep Intelisms into asm-generic which makes me very
uncomfortable. Whether we need to reserve some bits for "arch specific"
is one question, what we do with them ought not to be leaking out.
To start with trying to port code people will want to do
#define PROT_PKEY0 0
#define PROT_PKEY1 0
..
etc
next prev parent reply other threads:[~2015-05-07 19:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 17:41 [PATCH 00/12] [RFC] x86: Memory Protection Keys Dave Hansen
2015-05-07 17:41 ` [PATCH 02/12] x86, pku: define new CR4 bit Dave Hansen
2015-05-07 17:41 ` [PATCH 01/12] x86, pkeys: cpuid bit definition Dave Hansen
2015-05-07 17:41 ` [PATCH 03/12] x86, pkey: pkru xsave fields and data structure Dave Hansen
2015-05-07 17:41 ` [PATCH 04/12] x86, pkeys: PTE bits Dave Hansen
2015-05-07 17:41 ` [PATCH 06/12] x86, pkeys: store protection in high VMA flags Dave Hansen
2015-05-15 21:10 ` Thomas Gleixner
2015-05-15 21:13 ` Dave Hansen
2015-05-07 17:41 ` [PATCH 05/12] x86, pkeys: new page fault error code bit: PF_PK Dave Hansen
2015-05-07 17:41 ` [PATCH 08/12] x86, pkeys: arch-specific protection bits Dave Hansen
2015-05-07 17:41 ` [PATCH 07/12] mm: Pass the 4-bit protection key in via PROT_ bits to syscalls Dave Hansen
2015-05-07 19:11 ` One Thousand Gnomes [this message]
2015-05-07 19:19 ` Dave Hansen
2015-09-04 20:13 ` Florian Weimer
2015-09-04 20:18 ` Dave Hansen
2015-09-04 20:34 ` Florian Weimer
2015-09-04 20:41 ` Dave Hansen
2015-05-07 17:41 ` [PATCH 09/12] x86, pkeys: notify userspace about protection key faults Dave Hansen
2015-05-07 17:41 ` [PATCH 12/12] x86, pkeys: Documentation Dave Hansen
2015-05-07 17:41 ` [PATCH 11/12] x86, pkeys: actually enable Memory Protection Keys in CPU Dave Hansen
2015-05-07 17:41 ` [PATCH 10/12] x86, pkeys: differentiate Protection Key faults from normal Dave Hansen
2015-05-07 17:57 ` [PATCH 00/12] [RFC] x86: Memory Protection Keys Ingo Molnar
2015-05-07 18:09 ` Dave Hansen
2015-05-07 18:48 ` Vlastimil Babka
2015-05-07 21:45 ` Dave Hansen
2015-05-09 19:09 ` Dr. David Alan Gilbert
2015-05-07 19:18 ` One Thousand Gnomes
2015-05-07 19:26 ` Ingo Molnar
2015-05-07 19:40 ` Dave Hansen
2015-05-07 20:11 ` One Thousand Gnomes
2015-05-08 4:51 ` Ingo Molnar
2015-05-08 6:09 ` Kevin Easton
2015-05-07 19:22 ` Christian Borntraeger
2015-05-07 19:29 ` Dave Hansen
2015-05-07 19:45 ` Christian Borntraeger
2015-05-07 19:49 ` Dave Hansen
2015-05-07 19:57 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507201151.5658faa1@lxorguk.ukuu.org.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=dave@sr71.net \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®