From: Josh Triplett <josh@joshtriplett.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Michal Hocko <mhocko@suse.cz>,
Vladimir Davydov <vdavydov@parallels.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andy Lutomirski <luto@amacapital.net>,
Bertrand Jacquin <beber@meleeweb.net>,
"Luis R. Rodriguez" <mcgrof@suse.com>,
Iulia Manda <iulia.manda21@gmail.com>,
Pranith Kumar <bobby.prani@gmail.com>,
Clark Williams <clark.williams@gmail.com>,
Mel Gorman <mgorman@suse.de>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert
Date: Mon, 11 May 2015 14:18:25 -0700 [thread overview]
Message-ID: <20150511211825.GA12080@jtriplet-mobl1> (raw)
In-Reply-To: <1431378082.2398.97.camel@x220>
On Mon, May 11, 2015 at 11:01:22PM +0200, Paul Bolle wrote:
> On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote:
> > I'd also like to factor the "if EXPERT" off of all the prompts and into a
> > single scoped item wrapped around all of them, but kconfig doesn't have any way
> > to do that. "menuconfig" is just a hint, with no matching "endmenu" and no
> > implicit visibility; "menu" is scoped and has "visible if", but that would
> > create a separate option containing a menu, rather than a menu under EXPERT's
> > "Configure standard kernel features (expert users)". And "if EXPERT ... endif"
> > produces a dependency, not a prompt-visibility condition. So I think this
> > would require changes to the Kconfig language, to introduce either a scoped
> > "visible if EXPERT ... endvisible" or similar, or a scoped version of
> > menuconfig with a matching "endmenu" and implicit visibility (effectively a
> > "menu" statement with attached "config" rather than a "config" with a hint
> > "this might be a menu"). I'm leaning towards the latter.
>
> The behavior of menuconfig in this case is rather subtle. I must admit I
> never noticed it.
>
> The "visible" option to menus is little used, and I'm not really
> familiar with it. So, for what it's worth: would adding a new menu with
> visible if EXPERT
>
> attached to it, and putting all current
> prompt "Foo" if EXPERT
>
> entries in that menu roughly do what you want?
Not quite. menu has a prompt but no associated symbol, so with current
kconfig that would look like:
config EXPERT
bool "Configure standard kernel features (expert users)"
...
menu "Some separate menu prompt here"
visible if EXPERT
... various options that currently have if EXPERT on their prompts ...
endmenu
However, that would produce *two* entries under the "General setup"
menu: a yes/no entry "Configure standard kernel features (expert users)"
with no submenu, and a "Some separate menu prompt here" entry with a
submenu but no '[ ]' for a yes/no option. Integrating the two (without
using menuconfig's implicit "add stuff to submenu until an option's
prompt doesn't depend on this symbol" magic) requires new a kconfig
mechanism.
- Josh Triplett
next prev parent reply other threads:[~2015-05-11 21:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 18:13 [PATCH] init/Kconfig: Fix break in middle of EXPERT menu Josh Triplett
2015-05-11 18:23 ` Randy Dunlap
2015-05-11 20:23 ` [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert Josh Triplett
2015-05-11 21:01 ` Paul Bolle
2015-05-11 21:18 ` Josh Triplett [this message]
2015-05-11 21:32 ` Paul Bolle
2015-05-11 21:47 ` Josh Triplett
2015-05-11 22:01 ` Paul Bolle
2015-05-11 22:40 ` Josh Triplett
2015-05-11 21:50 ` Paul Bolle
2015-05-11 22:04 ` Josh Triplett
2015-05-11 22:15 ` Paul Bolle
2015-05-28 8:13 ` Paul Bolle
2015-05-11 22:36 ` Luis R. Rodriguez
2015-05-11 22:51 ` Josh Triplett
2015-05-12 7:04 ` [PATCH] init/Kconfig: Fix break in middle of EXPERT menu Ingo Molnar
2015-05-12 7:08 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511211825.GA12080@jtriplet-mobl1 \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=beber@meleeweb.net \
--cc=bobby.prani@gmail.com \
--cc=clark.williams@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hannes@cmpxchg.org \
--cc=iulia.manda21@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcgrof@suse.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pebolle@tiscali.nl \
--cc=rdunlap@infradead.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®