From: Steven Rostedt <rostedt@goodmis.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Kamil Debski <k.debski@samsung.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH][linux-next] coda: Do not define TRACE_SYSTEM_STRING
Date: Thu, 14 May 2015 22:58:57 -0400 [thread overview]
Message-ID: <20150514225857.27dc5965@grimm.local.home> (raw)
In-Reply-To: <20150514225250.70d2902f@grimm.local.home>
On Thu, 14 May 2015 22:52:50 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> TRACE_SYSTEM_STRING is used internally to the TRACE_EVENT system. It
> should not be defined by tracepoint files. I'm not even sure who
> started that (I hope it wasn't me!)
According to git history, that define first showed up in
commit 1c5d22f76dc721f3acb7a3dadc657a221e487fb7
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Tue Aug 25 11:15:50 2009 +0100
drm/i915: Add tracepoints
And it must have spread with cut and paste. Now I need to start
administering a vaccine to keep developers from catching it!
-- Steve
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org.
> ---
> diff --git a/drivers/media/platform/coda/trace.h b/drivers/media/platform/coda/trace.h
> index d1d06cbd1f6a..781bf7286d53 100644
> --- a/drivers/media/platform/coda/trace.h
> +++ b/drivers/media/platform/coda/trace.h
> @@ -9,8 +9,6 @@
>
> #include "coda.h"
>
> -#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
> -
> TRACE_EVENT(coda_bit_run,
> TP_PROTO(struct coda_ctx *ctx, int cmd),
>
next prev parent reply other threads:[~2015-05-15 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 2:52 Steven Rostedt
2015-05-15 2:58 ` Steven Rostedt [this message]
2015-05-20 9:42 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514225857.27dc5965@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=chris@chris-wilson.co.uk \
--cc=k.debski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®