* [PATCH 1/1 linux-next] udf: remove double err declaration in udf_file_write_iter()
@ 2015-05-15 21:26 Fabian Frederick
2015-05-18 6:16 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2015-05-15 21:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Jan Kara
Use first err declaration for generic_write_sync() return value.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/udf/file.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/udf/file.c b/fs/udf/file.c
index 7a95b8f..bddf3d0 100644
--- a/fs/udf/file.c
+++ b/fs/udf/file.c
@@ -152,8 +152,6 @@ out:
mutex_unlock(&inode->i_mutex);
if (retval > 0) {
- ssize_t err;
-
mark_inode_dirty(inode);
err = generic_write_sync(file, iocb->ki_pos - retval, retval);
if (err < 0)
--
2.4.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/1 linux-next] udf: remove double err declaration in udf_file_write_iter()
2015-05-15 21:26 [PATCH 1/1 linux-next] udf: remove double err declaration in udf_file_write_iter() Fabian Frederick
@ 2015-05-18 6:16 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2015-05-18 6:16 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Jan Kara
On Fri 15-05-15 23:26:28, Fabian Frederick wrote:
> Use first err declaration for generic_write_sync() return value.
Thanks. I've merged the patch.
Honza
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> fs/udf/file.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/udf/file.c b/fs/udf/file.c
> index 7a95b8f..bddf3d0 100644
> --- a/fs/udf/file.c
> +++ b/fs/udf/file.c
> @@ -152,8 +152,6 @@ out:
> mutex_unlock(&inode->i_mutex);
>
> if (retval > 0) {
> - ssize_t err;
> -
> mark_inode_dirty(inode);
> err = generic_write_sync(file, iocb->ki_pos - retval, retval);
> if (err < 0)
> --
> 2.4.0
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-18 6:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-15 21:26 [PATCH 1/1 linux-next] udf: remove double err declaration in udf_file_write_iter() Fabian Frederick
2015-05-18 6:16 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®