[PATCH 2/2] USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver()

[PATCH 2/2] USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver()

[Abhishek Bist]

This function is used to call before 2.6.x version of linux kernel but since then I haven't seen it's relative usage and it's not
being used any where right now after checking it through linux.crossrefrence.So, IMHO it would be relevant to remove this obselete
function from kernel mainline.

Signed-off-by: Abhishek Bist <ishubist@gmail.com>
---
 include/linux/usb/hcd.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
index 68b1e83..c9aa779 100644
--- a/include/linux/usb/hcd.h
+++ b/include/linux/usb/hcd.h
@@ -622,8 +622,6 @@ extern struct list_head usb_bus_list;
 extern struct mutex usb_bus_list_lock;
 extern wait_queue_head_t usb_kill_urb_queue;
 
-extern int usb_find_interface_driver(struct usb_device *dev,
-	struct usb_interface *interface);
 
 #define usb_endpoint_out(ep_dir)	(!((ep_dir) & USB_DIR_IN))
 
-- 
1.8.3.1

Re: [PATCH 2/2] USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver()

[Greg KH]

On Wed, May 27, 2015 at 07:19:15PM +0530, Abhishek Bist wrote:
> This function is used to call before 2.6.x version of linux kernel but since then I haven't seen it's relative usage and it's not
> being used any where right now after checking it through linux.crossrefrence.So, IMHO it would be relevant to remove this obselete
> function from kernel mainline.

Please properly wrap your changelog lines at 72 columns.

> Signed-off-by: Abhishek Bist <ishubist@gmail.com>
> ---
>  include/linux/usb/hcd.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index 68b1e83..c9aa779 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -622,8 +622,6 @@ extern struct list_head usb_bus_list;
>  extern struct mutex usb_bus_list_lock;
>  extern wait_queue_head_t usb_kill_urb_queue;
>  
> -extern int usb_find_interface_driver(struct usb_device *dev,
> -	struct usb_interface *interface);

Good catch, care to fix up the wording in your changelog and resend
this?

thanks,

greg k-h

Re: [PATCH 2/2] USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver()

[Greg KH]

On Wed, May 27, 2015 at 07:19:15PM +0530, Abhishek Bist wrote:
> This function is used to call before 2.6.x version of linux kernel but since then I haven't seen it's relative usage and it's not
> being used any where right now after checking it through linux.crossrefrence.So, IMHO it would be relevant to remove this obselete
> function from kernel mainline.
> 
> Signed-off-by: Abhishek Bist <ishubist@gmail.com>
> ---
>  include/linux/usb/hcd.h | 2 --
>  1 file changed, 2 deletions(-)

Where is patch 1/2?  I didn't get a copy of it...

Re: [PATCH 2/2] USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver()

[Paul Bolle]

On Wed, 2015-05-27 at 19:19 +0530, Abhishek Bist wrote:
> This function is used to call before 2.6.x version of linux kernel but
> since then I haven't seen it's relative usage and it's not
> being used any where right now after checking it through
> linux.crossrefrence.

This goes into detail way beyond what anyone sane cares for:
usb_find_interface_driver() was removed in v2.5.36 through a patch
titled "USB: Convert the core code to use struct device_driver.".

> So, IMHO it would be relevant to remove this obselete
> function from kernel mainline.

Thanks,


Paul Bolle

[PATCH] USB: hcd.h : Removed an unnecessary function prototype usb_find_interface_driver()

[Abhishek Bist]

This function is used to call in early version of linux kernel in order
to find out the interface used by a usb device. But now it's use is 
completely abolished. So,it would be relevant to remove this obselete
function from kernel mainline.

Signed-off-by: Abhishek Bist <ishubist@gmail.com>
---
 include/linux/usb/hcd.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
index 68b1e83..c9aa779 100644
--- a/include/linux/usb/hcd.h
+++ b/include/linux/usb/hcd.h
@@ -622,8 +622,6 @@ extern struct list_head usb_bus_list;
 extern struct mutex usb_bus_list_lock;
 extern wait_queue_head_t usb_kill_urb_queue;
 
-extern int usb_find_interface_driver(struct usb_device *dev,
-	struct usb_interface *interface);
 
 #define usb_endpoint_out(ep_dir)	(!((ep_dir) & USB_DIR_IN))
 
-- 
1.8.3.1