From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
jarod@redhat.com, jstancek@redhat.com
Subject: Re: [PATCH 1/2] prctl: more prctl(PR_SET_MM_*) checks
Date: Thu, 28 May 2015 01:02:29 +0300 [thread overview]
Message-ID: <20150527220229.GF17625@uranus.sw.swsoft.com> (raw)
In-Reply-To: <20150527214757.GA12863@p183.telecom.by>
On Thu, May 28, 2015 at 12:47:57AM +0300, Alexey Dobriyan wrote:
> Individual prctl(PR_SET_MM_*) calls do some checking to maintain
> consistent view of mm->arg_start et al fields, but not enough.
> In particular PR_SET_MM_ARG_START/PR_SET_MM_ARG_END/PR_SET_MM_ENV_START/PR_SET_MM_ENV_END
> only check that address lies in existent VMA, but doesn't check that
> start address is lower that end address _at all_.
>
> Consolidate all consistency checks, so there will be no difference in
> the future between PR_SET_MM_MAP and individual PR_SET_MM_* calls.
>
> The program below makes both ARGV and ENVP areas reverted,
> makes /proc/$PID/cmdline show garbage (doesn't oops by luck).
Why should it oops? Actually i would really love to drop off old
PR_SET_MM_ interface completely (which requires CAP_SYS_RESOURCE),
leaving only MM_MAP. But thank you!
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
next prev parent reply other threads:[~2015-05-27 22:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 21:47 Alexey Dobriyan
2015-05-27 21:49 ` [PATCH 2/2] proc: fix PAGE_SIZE limit of /proc/$PID/cmdline Alexey Dobriyan
2015-05-27 22:14 ` Cyrill Gorcunov
2015-05-27 22:29 ` Alexey Dobriyan
2015-05-27 22:48 ` Cyrill Gorcunov
2015-05-27 23:12 ` Alexey Dobriyan
2015-05-28 6:59 ` Cyrill Gorcunov
2015-05-28 11:14 ` Alexey Dobriyan
2015-05-28 11:35 ` Cyrill Gorcunov
2015-05-28 12:00 ` Cyrill Gorcunov
2015-05-28 11:57 ` Jan Stancek
2015-05-27 22:02 ` Cyrill Gorcunov [this message]
2015-05-27 22:12 ` [PATCH 1/2] prctl: more prctl(PR_SET_MM_*) checks Alexey Dobriyan
2015-05-27 22:20 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527220229.GF17625@uranus.sw.swsoft.com \
--to=gorcunov@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jarod@redhat.com \
--cc=jstancek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome