From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
jarod@redhat.com, jstancek@redhat.com
Subject: Re: [PATCH 2/2] proc: fix PAGE_SIZE limit of /proc/$PID/cmdline
Date: Thu, 28 May 2015 09:59:57 +0300 [thread overview]
Message-ID: <20150528065957.GJ17625@uranus.sw.swsoft.com> (raw)
In-Reply-To: <20150527231207.GA29641@p183.telecom.by>
On Thu, May 28, 2015 at 02:12:07AM +0300, Alexey Dobriyan wrote:
> > > >
> > > > Could you please explain why this down/up is needed?
> > >
> > > Code is written this way to get constistent snapshot of data.
> >
> > it does not. you fetch data into local variables which is the
> > same as simply read them locklessly in general (because later
> > you refer to local vars).
>
> It is snapshot w.r.t getting both pairs not snapshot w.r.t atomicity or
> something (unsigned long access is atomic after all). Once down_write()
> is used in the other place, it even becomes obviously correct code!
Not at all. It is correct if and only if you're operating under lock
taken, once you fetch the pair and left the lock it simply local copies
of values the descriptor had when lock was taken.
Cyrill
next prev parent reply other threads:[~2015-05-28 7:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 21:47 [PATCH 1/2] prctl: more prctl(PR_SET_MM_*) checks Alexey Dobriyan
2015-05-27 21:49 ` [PATCH 2/2] proc: fix PAGE_SIZE limit of /proc/$PID/cmdline Alexey Dobriyan
2015-05-27 22:14 ` Cyrill Gorcunov
2015-05-27 22:29 ` Alexey Dobriyan
2015-05-27 22:48 ` Cyrill Gorcunov
2015-05-27 23:12 ` Alexey Dobriyan
2015-05-28 6:59 ` Cyrill Gorcunov [this message]
2015-05-28 11:14 ` Alexey Dobriyan
2015-05-28 11:35 ` Cyrill Gorcunov
2015-05-28 12:00 ` Cyrill Gorcunov
2015-05-28 11:57 ` Jan Stancek
2015-05-27 22:02 ` [PATCH 1/2] prctl: more prctl(PR_SET_MM_*) checks Cyrill Gorcunov
2015-05-27 22:12 ` Alexey Dobriyan
2015-05-27 22:20 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528065957.GJ17625@uranus.sw.swsoft.com \
--to=gorcunov@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jarod@redhat.com \
--cc=jstancek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®