From: Mark Brown <broonie@kernel.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
cfreeman@nvidia.com, abrestic@chromium.org
Subject: Re: [PATCH 1/2] regulator: core: add support to get VSEL register from hw driver
Date: Thu, 28 May 2015 14:52:45 +0100 [thread overview]
Message-ID: <20150528135245.GU21577@sirena.org.uk> (raw)
In-Reply-To: <1432737621-27590-1-git-send-email-ldewangan@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On Wed, May 27, 2015 at 08:10:20PM +0530, Laxman Dewangan wrote:
> Add callback on the regulator ops to get the voltage selection
> register address and mask from device regulator driver. Use this
> new callback in regulator_get_hardware_vsel_register().
It's not entirely clear to me that this is a good idea - the expected
use case for getting the vsel register is to hand it off to something
like a microcontroller for it to use but if the vsel register might
change at runtime then we also need infrastructure to synchronize those
changes with whatever is using the register. How does your system keep
them in sync?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-28 13:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 14:40 Laxman Dewangan
2015-05-27 14:40 ` [PATCH 2/2] regulator: max8973: Implement callback to get vsel and mask Laxman Dewangan
2015-05-28 13:52 ` Mark Brown [this message]
2015-05-29 5:51 ` [PATCH 1/2] regulator: core: add support to get VSEL register from hw driver Laxman Dewangan
2015-05-29 9:49 ` Mark Brown
2015-05-29 11:43 ` Laxman Dewangan
2015-06-05 13:36 ` Laxman Dewangan
2015-06-05 16:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528135245.GU21577@sirena.org.uk \
--to=broonie@kernel.org \
--cc=abrestic@chromium.org \
--cc=cfreeman@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®