mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
	olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com,
	jasowang@redhat.com
Subject: Re: [PATCH V2 3/3] Drivers: hv: vmbus: Allocate ring buffer memory in NUMA aware fashion
Date: Sun, 31 May 2015 15:41:14 +0900	[thread overview]
Message-ID: <20150531064114.GB7057@kroah.com> (raw)
In-Reply-To: <1433054269-22278-3-git-send-email-kys@microsoft.com>

On Sat, May 30, 2015 at 11:37:49PM -0700, K. Y. Srinivasan wrote:
> Allocate ring buffer memory from the NUMA node assigned to the channel.

But you do more than just that.  If there's a failure, you fall-back to
the old allocation method.  Why not mention that as well?

And is that what you really want?  Do we ever fail allocation for a node
but still have memory from another one?  Shouldn't the logic be in the
allocator and not be forced to be in every caller?

thanks,

greg k-h

  reply	other threads:[~2015-05-31  6:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-31  6:37 [PATCH V2 0/3] Drivers: hv: vmbus: Make VMBUS driver NUMA aware K. Y. Srinivasan
2015-05-31  6:37 ` [PATCH V2 1/3] Drivers: hv: vmbus: Use the vp_index map even for channels bound to CPU 0 K. Y. Srinivasan
2015-05-31  6:37   ` [PATCH V2 2/3] Drivers: hv: vmbus: Implement NUMA aware CPU affinity for channels K. Y. Srinivasan
2015-05-31  6:37   ` [PATCH V2 3/3] Drivers: hv: vmbus: Allocate ring buffer memory in NUMA aware fashion K. Y. Srinivasan
2015-05-31  6:41     ` Greg KH [this message]
2015-05-31 18:39       ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150531064114.GB7057@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=jasowang@redhat.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome