From: Mark Brown <broonie@kernel.org>
To: Nariman Poushin <nariman@opensource.wolfsonmicro.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [RFC][PATCH] regmap: Add reg_sequence for use with multi_reg_write / register_patch
Date: Tue, 2 Jun 2015 19:15:13 +0100 [thread overview]
Message-ID: <20150602181512.GC14071@sirena.org.uk> (raw)
In-Reply-To: <20150601092012.GA31354@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 544 bytes --]
On Mon, Jun 01, 2015 at 10:20:12AM +0100, Nariman Poushin wrote:
> it be accepted), should I:
> - Squash all the updates in to this patch (I suppose the benefit
> there is that we don't break the kernel build from one patch
> to the other)
You need to squash the changes in since they break bisection if handled
separately. It would be better to do this by having a separate patch to
add the newly named structure rather than adding the new functionality
at the same time. That makes the patch more mechanical and easier to
review.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-06-02 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 9:20 Nariman Poushin
2015-06-02 18:15 ` Mark Brown [this message]
2015-06-04 14:21 ` Nariman Poushin
2015-06-04 17:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602181512.GC14071@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nariman@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®