From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] workqueue: introduce get_pwq_unlocked()
Date: Thu, 4 Jun 2015 10:04:54 +0900 [thread overview]
Message-ID: <20150604010454.GJ20091@mtj.duckdns.org> (raw)
In-Reply-To: <1433341792-2017-2-git-send-email-laijs@cn.fujitsu.com>
Hello,
On Wed, Jun 03, 2015 at 10:29:49PM +0800, Lai Jiangshan wrote:
> attrs management code may reuse existed pwq and it has open code
existing
> to do "lock();get_pwq();unlock()", we move this open code into
> get_pwq_unlocked().
>
> get_pwq_unlocked() will also be used in later patches to allow
> apply_wqattrs_prepare() to resue the original default or per-node pwq.
reuse
> /**
> + * get_pwq_unlocked - get_pwq() with surrounding pool lock/unlock
> + * @pwq: pool_workqueue to get (should not %NULL)
should not be %NULL
> + *
> + * get_pwq() with locking. The caller should have at least an owned
> + * reference on @pwq to match the guarantees required by get_pwq().
The caller should have a reference on @pwq.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-06-04 1:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 14:29 [PATCH 0/4 V3] workqueue: avoid creating identical pwqs Lai Jiangshan
2015-06-03 14:29 ` [PATCH 1/4] workqueue: introduce get_pwq_unlocked() Lai Jiangshan
2015-06-04 1:04 ` Tejun Heo [this message]
2015-06-03 14:29 ` [PATCH 2/4] workqueue: reuse the current per-node pwq when its attrs are unchanged Lai Jiangshan
2015-06-04 1:05 ` Tejun Heo
2015-06-03 14:29 ` [PATCH 3/4] workqueue: reuse the current default pwq when its attrs unchanged Lai Jiangshan
2015-06-03 14:29 ` [PATCH 4/4] workqueue: reuse wq_update_unbound_numa_attrs_buf as temporary attrs Lai Jiangshan
2015-06-04 1:09 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150604010454.GJ20091@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome