mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] workqueue: reuse the current per-node pwq when its attrs are unchanged
Date: Thu, 4 Jun 2015 10:05:47 +0900	[thread overview]
Message-ID: <20150604010547.GK20091@mtj.duckdns.org> (raw)
In-Reply-To: <1433341792-2017-3-git-send-email-laijs@cn.fujitsu.com>

On Wed, Jun 03, 2015 at 10:29:50PM +0800, Lai Jiangshan wrote:
> If the cpumask is changed, it is possible that only a part of the per-node
> pwq is affected.  This can happen when the user changes the cpumask of
> a workqueue or the low level cpumask.
> 
> So we try to reuse the current per-node pwq when its attrs are unchanged.
> 
> In wq_update_unbound_numa(), we had already made the current pwq be
> reused when its attrs are unaffected, but we move the code of fetching
> current pwq closer to the code of testing.
> 
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>

This one looks good to me.

Thanks.

-- 
tejun

  reply	other threads:[~2015-06-04  1:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 14:29 [PATCH 0/4 V3] workqueue: avoid creating identical pwqs Lai Jiangshan
2015-06-03 14:29 ` [PATCH 1/4] workqueue: introduce get_pwq_unlocked() Lai Jiangshan
2015-06-04  1:04   ` Tejun Heo
2015-06-03 14:29 ` [PATCH 2/4] workqueue: reuse the current per-node pwq when its attrs are unchanged Lai Jiangshan
2015-06-04  1:05   ` Tejun Heo [this message]
2015-06-03 14:29 ` [PATCH 3/4] workqueue: reuse the current default pwq when its attrs unchanged Lai Jiangshan
2015-06-03 14:29 ` [PATCH 4/4] workqueue: reuse wq_update_unbound_numa_attrs_buf as temporary attrs Lai Jiangshan
2015-06-04  1:09   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150604010547.GK20091@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome