From: Tejun Heo <htejun@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Louis Langholtz <lou_langholtz@me.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
trivial@kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] kernel/params.c: make use of unused but set variable
Date: Mon, 8 Jun 2015 09:58:48 +0900 [thread overview]
Message-ID: <20150608005848.GA21465@mtj.duckdns.org> (raw)
In-Reply-To: <CA+55aFwmOGaP1DN3frkfP+Df=jCwURqO22A6-5GqpMnZXkvMXA@mail.gmail.com>
On Sun, Jun 07, 2015 at 05:17:20PM -0700, Linus Torvalds wrote:
> At most, it could be a "WARN_ON_ONCE()". Maybe even just silently
> ignore the error. But BUG_ON()? Hell no.
Yeah, WARN_ON_ONCE() is the right one. The short history here is that
sysfs_create_file() has __must_check on it which triggered this whole
discussion. The rationale for having __must_check on the function was
that the function's failure leads to userland visible behavior
difference and it's very inviting to skip error handling on the
function as file creation is often the last operation to be performed
with no further dependency on it.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-06-08 0:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <http://marc.info/?l=linux-kernel&m=143351431301630>
2015-06-07 23:54 ` Louis Langholtz
2015-06-08 0:00 ` Tejun Heo
2015-06-08 0:17 ` Linus Torvalds
2015-06-08 0:58 ` Tejun Heo [this message]
2015-06-08 5:24 ` [PATCH v2] " Louis Langholtz
2015-06-10 17:05 ` [PATCH] " Louis Langholtz
2015-06-11 1:54 ` Tejun Heo
2015-06-12 3:17 ` Louis Langholtz
2015-06-08 5:44 ` [PATCH] checkpatch: Warn on BUG and BUG_ON uses Joe Perches
2015-06-08 5:46 ` [PATCH] kernel/params.c: make use of unused but set variable Louis Langholtz
2015-06-08 7:12 ` [PATCH] debug: Deprecate BUG_ON() use in new code, introduce CRASH_ON() Ingo Molnar
2015-06-08 7:40 ` Alexander Holler
2015-06-08 8:08 ` Richard Weinberger
2015-06-08 8:42 ` Alexander Holler
2015-06-08 9:05 ` Ingo Molnar
2015-06-08 9:11 ` Ingo Molnar
2015-06-08 9:22 ` Alexander Holler
2015-06-08 11:29 ` Ingo Molnar
2015-06-08 9:16 ` Alexander Holler
2015-06-08 11:27 ` Ingo Molnar
2015-06-08 18:07 ` Alexander Holler
2015-06-08 19:35 ` Ingo Molnar
2015-06-09 1:07 ` Alexander Holler
2015-06-08 8:09 ` Ingo Molnar
2015-06-12 1:27 ` [PATCH] kernel/params.c: make use of unused but set variable Rusty Russell
2015-06-12 1:48 ` Tejun Heo
2015-06-14 19:49 ` Rusty Russell
2015-06-16 19:54 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608005848.GA21465@mtj.duckdns.org \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lou_langholtz@me.com \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome