mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Nariman Poushin <nariman@opensource.wolfsonmicro.com>
Cc: patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] regmap: make REGCACHE_NONE maps return error on regcache_sync
Date: Mon, 8 Jun 2015 18:24:51 +0100	[thread overview]
Message-ID: <20150608172451.GJ14071@sirena.org.uk> (raw)
In-Reply-To: <20150608141641.GA9236@opensource.wolfsonmicro.com>

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

On Mon, Jun 08, 2015 at 03:16:41PM +0100, Nariman Poushin wrote:

> In light of this:
> https://lkml.org/lkml/2015/6/7/193

Please provide human readable descriptions for things, people don't
always read online and it at least means going to another program to
figure out what's being discussed.

> Would it be prudent to now  make these WARN_ON? It seems like it's not
> worth taking the kernel down in the case where you are trying to sync to
> a non-existent cache for a peripheral. Of course it could be that the 

This is nothing new on Linus' part, really - as he himself says.  We're
being cautious here because we are often controlling devices like PMICs
and battery chargers where we're worried about physically damaging the
system if we get things too wrong, one thing that might possibly have
been happening here is that we've got very confused about what we're
doing with a critical system component.  There's certainly a case for
having some handling that's less severe but it does need to be something
that people notice and which is conservative about interacting with the
device after it noticed the problem.

In any case, if you want to propose a code change then please submit a
patch.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

      reply	other threads:[~2015-06-08 17:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08  9:55 Nariman Poushin
2015-05-08 10:20 ` Mark Brown
2015-05-08 10:34   ` Nariman Poushin
2015-06-08 14:16     ` Nariman Poushin
2015-06-08 17:24       ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150608172451.GJ14071@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nariman@opensource.wolfsonmicro.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®