From: Mark Brown <broonie@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
lgirdwood@gmail.com
Subject: Re: [PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away
Date: Mon, 8 Jun 2015 19:07:18 +0100 [thread overview]
Message-ID: <20150608180718.GR14071@sirena.org.uk> (raw)
In-Reply-To: <1433529771-24496-6-git-send-email-lee.jones@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
On Fri, Jun 05, 2015 at 07:42:48PM +0100, Lee Jones wrote:
> Perhaps this is just personal preference, but ...
Possibly...
> Prevents this kind of nonsense:
> this->is->just.silly = fetch_silly_value(&pointer);
> if (!this->is->just.silly) {
> printk("Silly value failed: %d\n", this->is->just.silly);
> return this->is->just.silly;
> }
But we don't have any of that code? Well, one if statement where we
check config.init_data but that's it. A temporary does help with things
like the above but we're not doing that in this driver are we?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-06-08 18:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 18:42 [PATCH 0/8] regulator: pwm-regulator: Introduce continuous-mode Lee Jones
2015-06-05 18:42 ` [PATCH 1/8] ARM: STi: STiH407: Add PWM Regulator node Lee Jones
2015-06-05 18:42 ` [PATCH 2/8] regulator: pwm-regulator: Remove unnecessary descriptor attribute from ddata Lee Jones
2015-06-08 18:11 ` Mark Brown
2015-06-05 18:42 ` [PATCH 3/8] regulator: pwm-regulator: Remove superfluous is_enabled check Lee Jones
2015-06-08 18:11 ` Mark Brown
2015-06-05 18:42 ` [PATCH 4/8] regulator: pwm-regulator: Diffientiate between dev (device) and rdev (regulator_dev) Lee Jones
2015-06-08 18:11 ` Mark Brown
2015-06-05 18:42 ` [PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away Lee Jones
2015-06-08 18:07 ` Mark Brown [this message]
2015-06-09 7:03 ` Lee Jones
2015-06-09 10:10 ` Mark Brown
2015-06-09 11:07 ` Lee Jones
2015-06-05 18:42 ` [PATCH 6/8] regulator: pwm-regulator: Separate voltage-table initialisation Lee Jones
2015-06-09 17:14 ` Mark Brown
2015-06-10 7:58 ` Lee Jones
2015-06-05 18:42 ` [PATCH 7/8] regulator: pwm-regulator: Add support for continuous-voltage Lee Jones
2015-06-05 18:42 ` [PATCH 8/8] dt: regulator: pwm-regulator: Re-write bindings Lee Jones
2015-06-05 18:47 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608180718.GR14071@sirena.org.uk \
--to=broonie@kernel.org \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®