From: Johannes Thumshirn <jthumshirn@suse.de>
To: Colin King <colin.king@canonical.com>
Cc: Kashyap Desai <kashyap.desai@avagotech.com>,
Sumit Saxena <sumit.saxena@avagotech.com>,
Uday Lingala <uday.lingala@avagotech.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] megaraid_sas: insert missing space in kernel message
Date: Wed, 10 Jun 2015 08:30:16 +0200 [thread overview]
Message-ID: <20150610063016.GA2780@c203.arch.suse.de> (raw)
In-Reply-To: <1433865223-15310-1-git-send-email-colin.king@canonical.com>
On Tue, Jun 09, 2015 at 04:53:43PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The printk format specifier string is missing a space between
> the %p format specifier and the "on the defer" text. Minor fix,
> add the missing space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 890637f..4889ef6 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -3148,7 +3148,7 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance)
> cmd = instance->cmd_list[i];
> if (cmd->sync_cmd == 1 || cmd->scmd) {
> printk(KERN_NOTICE "megasas: moving cmd[%d]:%p:%d:%p"
> - "on the defer queue as internal\n",
> + " on the defer queue as internal\n",
> defer_index, cmd, cmd->sync_cmd, cmd->scmd);
>
> if (!list_empty(&cmd->list)) {
> --
> 2.1.4
>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
prev parent reply other threads:[~2015-06-10 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 15:53 Colin King
2015-06-10 6:29 ` Sumit Saxena
2015-06-10 6:30 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610063016.GA2780@c203.arch.suse.de \
--to=jthumshirn@suse.de \
--cc=JBottomley@odin.com \
--cc=colin.king@canonical.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@avagotech.com \
--cc=sumit.saxena@avagotech.com \
--cc=uday.lingala@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®