From: Sumit Saxena <sumit.saxena@avagotech.com>
To: Colin King <colin.king@canonical.com>,
Kashyap Desai <kashyap.desai@avagotech.com>,
Uday Lingala <uday.lingala@avagotech.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
"PDL,MEGARAIDLINUX" <megaraidlinux.pdl@avagotech.com>,
linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: RE: [PATCH] megaraid_sas: insert missing space in kernel message
Date: Wed, 10 Jun 2015 11:59:42 +0530 [thread overview]
Message-ID: <e7d8e98d9cc2276cd576a987d762e16b@mail.gmail.com> (raw)
In-Reply-To: <1433865223-15310-1-git-send-email-colin.king@canonical.com>
>-----Original Message-----
>From: Colin King [mailto:colin.king@canonical.com]
>Sent: Tuesday, June 09, 2015 9:24 PM
>To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E.J. Bottomley;
>megaraidlinux.pdl@avagotech.com; linux-scsi@vger.kernel.org
>Cc: linux-kernel@vger.kernel.org
>Subject: [PATCH] megaraid_sas: insert missing space in kernel message
>
>From: Colin Ian King <colin.king@canonical.com>
>
>The printk format specifier string is missing a space between the %p
format
>specifier and the "on the defer" text. Minor fix, add the missing space.
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
>---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>b/drivers/scsi/megaraid/megaraid_sas_base.c
>index 890637f..4889ef6 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_base.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>@@ -3148,7 +3148,7 @@ megasas_internal_reset_defer_cmds(struct
>megasas_instance *instance)
> cmd = instance->cmd_list[i];
> if (cmd->sync_cmd == 1 || cmd->scmd) {
> printk(KERN_NOTICE "megasas: moving
>cmd[%d]:%p:%d:%p"
>- "on the defer queue as
internal\n",
>+ " on the defer queue as
internal\n",
> defer_index, cmd, cmd->sync_cmd, cmd-
>>scmd);
>
> if (!list_empty(&cmd->list)) {
Acked-by: Sumit Saxena <sumit.saxena@avagotech.com>
>--
>2.1.4
next prev parent reply other threads:[~2015-06-10 6:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 15:53 Colin King
2015-06-10 6:29 ` Sumit Saxena [this message]
2015-06-10 6:30 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7d8e98d9cc2276cd576a987d762e16b@mail.gmail.com \
--to=sumit.saxena@avagotech.com \
--cc=JBottomley@odin.com \
--cc=colin.king@canonical.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@avagotech.com \
--cc=uday.lingala@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®