From: Steven Rostedt <rostedt@goodmis.org>
To: Wang Long <long.wanglong@huawei.com>
Cc: <mingo@redhat.com>, <wanglong@laoqinren.net>,
<linux-kernel@vger.kernel.org>, <peifeiyue@huawei.com>
Subject: Re: [PATCH] ring-buffer-benchmark: Fix the wrong param in module_param
Date: Wed, 10 Jun 2015 15:44:50 -0400 [thread overview]
Message-ID: <20150610154450.108e33c4@gandalf.local.home> (raw)
In-Reply-To: <1433923873-67712-1-git-send-email-long.wanglong@huawei.com>
On Wed, 10 Jun 2015 08:11:13 +0000
Wang Long <long.wanglong@huawei.com> wrote:
> The {producer|consumer}_{nice|fifo} parameters are integer
> type, we should use 'int' as the second param in module_param.
>
> For example(consumer_fifo):
> the default value of consumer_fifo is -1.
> Without this patch:
> # cat /sys/module/ring_buffer_benchmark/parameters/consumer_fifo
> 4294967295
> With this patch:
> # cat /sys/module/ring_buffer_benchmark/parameters/consumer_fifo
> -1
>
> Signed-off-by: Wang Long <long.wanglong@huawei.com>
> ---
Thanks, Applied!
-- Steve
prev parent reply other threads:[~2015-06-10 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 8:11 Wang Long
2015-06-10 19:44 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610154450.108e33c4@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=long.wanglong@huawei.com \
--cc=mingo@redhat.com \
--cc=peifeiyue@huawei.com \
--cc=wanglong@laoqinren.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®