mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vlad Dogaru <vlad.dogaru@intel.com>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: jic23@kernel.org, pmeerw@pmeerw.net, tiberiu.a.breana@intel.com,
	knaack.h@gmx.de, lars@metafoo.de, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: proximity: sx9500: Fix proximity value
Date: Fri, 12 Jun 2015 10:40:47 +0300	[thread overview]
Message-ID: <20150612074046.GB14044@vdogaru> (raw)
In-Reply-To: <1434037774-22081-3-git-send-email-daniel.baluta@intel.com>

On Thu, Jun 11, 2015 at 06:49:34PM +0300, Daniel Baluta wrote:
> Because of the ABI confusion proximity value exposed by SX9500
> was inverted.
> 
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>

Reviewed-by: Vlad Dogaru <vlad.dogaru@intel.com>

Sorry for causing the confusion, it was the only proximity sensor I had
encountered to date.

> ---
>  drivers/iio/proximity/sx9500.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/proximity/sx9500.c b/drivers/iio/proximity/sx9500.c
> index 2042e37..01494cd 100644
> --- a/drivers/iio/proximity/sx9500.c
> +++ b/drivers/iio/proximity/sx9500.c
> @@ -281,7 +281,7 @@ static int sx9500_read_prox_data(struct sx9500_data *data,
>  	if (ret < 0)
>  		return ret;
>  
> -	*val = 32767 - (s16)be16_to_cpu(regval);
> +	*val = be16_to_cpu(regval);
>  
>  	return IIO_VAL_INT;
>  }
> -- 
> 1.9.1
> 

  reply	other threads:[~2015-06-12  7:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 15:49 [PATCH 0/2] Clarify proximity output value interpretation Daniel Baluta
2015-06-11 15:49 ` [PATCH 1/2] iio: ABI: Clarify proximity output value Daniel Baluta
2015-06-16 20:41   ` Peter Meerwald
2015-06-21 13:39     ` Jonathan Cameron
2015-06-11 15:49 ` [PATCH 2/2] iio: proximity: sx9500: Fix proximity value Daniel Baluta
2015-06-12  7:40   ` Vlad Dogaru [this message]
2015-06-13 18:21     ` Jonathan Cameron
2015-06-13 18:32       ` Daniel Baluta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150612074046.GB14044@vdogaru \
    --to=vlad.dogaru@intel.com \
    --cc=daniel.baluta@intel.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=tiberiu.a.breana@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®