From: Peter Meerwald <pmeerw@pmeerw.net>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: jic23@kernel.org, vlad.dogaru@intel.com,
tiberiu.a.breana@intel.com, knaack.h@gmx.de, lars@metafoo.de,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: ABI: Clarify proximity output value
Date: Tue, 16 Jun 2015 22:41:05 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1506162234100.22088@pmeerw.net> (raw)
In-Reply-To: <1434037774-22081-2-git-send-email-daniel.baluta@intel.com>
Hello,
> Current description for proximity measurement is ambiguous. While
> the first part says that proximity is measured by observing
> reflectivity, the second part incorrectly infers that reported values
> should behave like a distance.
>
> This is because of AS3935 lightning sensor which uses the proximity
> API, while not being a true proximity sensor.
Acked-by: Peter Meerwald <pmeerw@pmeerw.net>
> Fixes: 614e8842ddf ("iio: ABI: add clarification for proximity")
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
> ---
> Documentation/ABI/testing/sysfs-bus-iio | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index bbed111..70c9b1a 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -1234,10 +1234,8 @@ Description:
> object is near the sensor, usually be observing
> reflectivity of infrared or ultrasound emitted.
> Often these sensors are unit less and as such conversion
> - to SI units is not possible. Where it is, the units should
> - be meters. If such a conversion is not possible, the reported
> - values should behave in the same way as a distance, i.e. lower
> - values indicate something is closer to the sensor.
> + to SI units is not possible. Higher proximity measurements
> + indicate closer objects, and vice versa.
>
> What: /sys/.../iio:deviceX/in_illuminance_input
> What: /sys/.../iio:deviceX/in_illuminance_raw
>
--
Peter Meerwald
+43-664-2444418 (mobile)
next prev parent reply other threads:[~2015-06-16 20:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 15:49 [PATCH 0/2] Clarify proximity output value interpretation Daniel Baluta
2015-06-11 15:49 ` [PATCH 1/2] iio: ABI: Clarify proximity output value Daniel Baluta
2015-06-16 20:41 ` Peter Meerwald [this message]
2015-06-21 13:39 ` Jonathan Cameron
2015-06-11 15:49 ` [PATCH 2/2] iio: proximity: sx9500: Fix proximity value Daniel Baluta
2015-06-12 7:40 ` Vlad Dogaru
2015-06-13 18:21 ` Jonathan Cameron
2015-06-13 18:32 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1506162234100.22088@pmeerw.net \
--to=pmeerw@pmeerw.net \
--cc=daniel.baluta@intel.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiberiu.a.breana@intel.com \
--cc=vlad.dogaru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®