* Re: [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init [not found] <1430709902-10815-1-git-send-email-xerofoify@gmail.com> @ 2015-06-18 16:41 ` Alexandre Belloni 2015-06-18 19:04 ` Alexandre Belloni 0 siblings, 1 reply; 3+ messages in thread From: Alexandre Belloni @ 2015-06-18 16:41 UTC (permalink / raw) To: Nicholas Krause Cc: balbi, gregkh, nicolas.ferre, boris.brezillon, peter.chen, ronald.wahl, voice.shen, linux-usb, linux-kernel On 03/05/2015 at 23:25:02 -0400, Nicholas Krause wrote : > This simplifies the error checking of the function,at91sam9261_udc_init > by using PTR_ERR_OR_ZERO in the return statement rather then a unnessary > if statement to check the return value of a call to the function, > syscon_regmap_lookup_by_phandle by checking with a call to the function, > IS_ERR and returning a error pointer if there is one for the function, > at91sam9261_udc_init. Furthermore this was found by running coccinelle > against the lastest kernel tree. > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init 2015-06-18 16:41 ` [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init Alexandre Belloni @ 2015-06-18 19:04 ` Alexandre Belloni 2015-06-18 19:31 ` Greg KH 0 siblings, 1 reply; 3+ messages in thread From: Alexandre Belloni @ 2015-06-18 19:04 UTC (permalink / raw) To: Nicholas Krause Cc: balbi, gregkh, nicolas.ferre, boris.brezillon, peter.chen, ronald.wahl, voice.shen, linux-usb, linux-kernel On 18/06/2015 at 18:41:14 +0200, Alexandre Belloni wrote : > On 03/05/2015 at 23:25:02 -0400, Nicholas Krause wrote : > > This simplifies the error checking of the function,at91sam9261_udc_init > > by using PTR_ERR_OR_ZERO in the return statement rather then a unnessary > > if statement to check the return value of a call to the function, > > syscon_regmap_lookup_by_phandle by checking with a call to the function, > > IS_ERR and returning a error pointer if there is one for the function, > > at91sam9261_udc_init. Furthermore this was found by running coccinelle > > against the lastest kernel tree. > > > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > OK, it seems the original patch got ignored by all the mailing lists. To bad, that one was actually applicable :) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init 2015-06-18 19:04 ` Alexandre Belloni @ 2015-06-18 19:31 ` Greg KH 0 siblings, 0 replies; 3+ messages in thread From: Greg KH @ 2015-06-18 19:31 UTC (permalink / raw) To: Alexandre Belloni Cc: Nicholas Krause, balbi, nicolas.ferre, boris.brezillon, peter.chen, ronald.wahl, voice.shen, linux-usb, linux-kernel On Thu, Jun 18, 2015 at 09:04:52PM +0200, Alexandre Belloni wrote: > On 18/06/2015 at 18:41:14 +0200, Alexandre Belloni wrote : > > On 03/05/2015 at 23:25:02 -0400, Nicholas Krause wrote : > > > This simplifies the error checking of the function,at91sam9261_udc_init > > > by using PTR_ERR_OR_ZERO in the return statement rather then a unnessary > > > if statement to check the return value of a call to the function, > > > syscon_regmap_lookup_by_phandle by checking with a call to the function, > > > IS_ERR and returning a error pointer if there is one for the function, > > > at91sam9261_udc_init. Furthermore this was found by running coccinelle > > > against the lastest kernel tree. > > > > > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > > Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > > > > OK, it seems the original patch got ignored by all the mailing lists. To > bad, that one was actually applicable :) Nick is banned from vger.kernel.org, so that is why his patches will not ever show up. I recommend that you do the same if possible. greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-18 19:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1430709902-10815-1-git-send-email-xerofoify@gmail.com>
2015-06-18 16:41 ` [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init Alexandre Belloni
2015-06-18 19:04 ` Alexandre Belloni
2015-06-18 19:31 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®