mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave@sr71.net>
To: dave@sr71.net
Cc: dave.hansen@linux.intel.com, john@johnmccutchan.com,
	rlove@rlove.org, eparis@parisplace.org, viro@zeniv.linux.org.uk,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [PATCH] fs: inotify: systemd needs it so make it depend on CONFIG_EMBEDDED
Date: Fri, 19 Jun 2015 11:07:42 -0700	[thread overview]
Message-ID: <20150619180742.62D31523@viggo.jf.intel.com> (raw)


From: Dave Hansen <dave.hansen@linux.intel.com>

I have a little microbenchmark that sits and does write() in a loop.
The number one kernel function in the profiles is __srcu_read_lock()
from fsnotify().  I decided to turn off INOTIFY in order to see what
the potential from optimizing this path would be.  I ended up with
a system at the rescue console as systemd complained that dependencies
were not met mounting some non-root filesystems:

	systemd: inotify_init1() failed: Function not implemented
	systemd: Dependency failed for Mark the need to relabel after reboot.
	systemd: Triggering OnFailure= dependencies of local-fs.target.
	systemd: inotify_init1() failed: Function not implemented
	systemd: Dependency failed for /gcc.

It looks like CONFIG_INOTIFY is now a critical part of any system
that wants to both use systemd and boot.  Let's make it depend
on CONFIG_EMBEDDED.

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: John McCutchan <john@johnmccutchan.com>
Cc: Robert Love <rlove@rlove.org>
Cc: Eric Paris <eparis@parisplace.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org

---

 b/fs/notify/inotify/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/notify/inotify/Kconfig~make-inotify-harder-to-turn-off fs/notify/inotify/Kconfig
--- a/fs/notify/inotify/Kconfig~make-inotify-harder-to-turn-off	2015-06-19 10:54:06.528721072 -0700
+++ b/fs/notify/inotify/Kconfig	2015-06-19 10:55:16.426892530 -0700
@@ -1,5 +1,5 @@
 config INOTIFY_USER
-	bool "Inotify support for userspace"
+	bool "Inotify support for userspace" if EMBEDDED
 	select ANON_INODES
 	select FSNOTIFY
 	default y
_
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

             reply	other threads:[~2015-06-19 18:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-19 18:07 Dave Hansen [this message]
2015-06-19 18:18 ` Ilia Mirkin
2015-06-19 18:54   ` Austin S Hemmelgarn
2015-06-19 21:48   ` Dave Hansen
2015-06-22 12:20     ` Austin S Hemmelgarn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150619180742.62D31523@viggo.jf.intel.com \
    --to=dave@sr71.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=eparis@parisplace.org \
    --cc=john@johnmccutchan.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rlove@rlove.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome