From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux FS Dev Mailing List <linux-fsdevel@vger.kernel.org>,
Linux F2FS Dev Mailing List
<linux-f2fs-devel@lists.sourceforge.net>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [GIT PULL] f2fs updates for v4.2
Date: Wed, 24 Jun 2015 23:48:26 -0700 [thread overview]
Message-ID: <20150625064522.GA44674@jaegeuk-mac02.mot-mobility.com> (raw)
In-Reply-To: <20150625063235.GV17109@ZenIV.linux.org.uk>
On Thu, Jun 25, 2015 at 07:32:36AM +0100, Al Viro wrote:
> On Wed, Jun 24, 2015 at 10:50:10PM -0700, Jaegeuk Kim wrote:
>
> > Right, I missed merging the fix-up patch in linux-next into my pull-request.
> > At a glance, I think there is no problem; except 80 column width, though.
> >
> > Also, agreed that I need to take a look at deleting the dentry to deal with that
> > failure case.
>
> Why not set the symlink up first and create a directory entry only
> if that succeeds? Looks like it's less work that way...
Cause f2fs_add_link initializes some on-disk inode structures to be used when
writing data.
Maybe simply call f2fs_unlink?
next prev parent reply other threads:[~2015-06-25 6:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 20:25 Jaegeuk Kim
2015-06-25 3:42 ` Linus Torvalds
2015-06-25 4:33 ` Al Viro
2015-06-25 5:50 ` Jaegeuk Kim
2015-06-25 6:32 ` Al Viro
2015-06-25 6:48 ` Jaegeuk Kim [this message]
2015-06-25 6:29 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625064522.GA44674@jaegeuk-mac02.mot-mobility.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®