From: Jean Delvare <jdelvare@suse.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Constantine Shulyupin <const@MakeLinux.com>,
open@suse.de, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] hwmon: (nct7802) Add pwm control
Date: Sun, 5 Jul 2015 08:57:27 +0200 [thread overview]
Message-ID: <20150705085727.23e25d08@endymion.delvare> (raw)
In-Reply-To: <55982124.2070500@roeck-us.net>
On Sat, 04 Jul 2015 11:08:36 -0700, Guenter Roeck wrote:
> Hi Constantine,
>
> On 07/04/2015 07:57 AM, Constantine Shulyupin wrote:
> > Added fan output control registers.
> > Modes of operation are PWM (default) and DC.
> >
>
> Another note: Since you mention DC vs. pwm mode, have you
> considered adding pwm[123]_mode attributes to report the
> selected mode ?
If you do, please make sure these attributes are read-only.
Thanks,
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2015-07-05 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-04 14:57 Constantine Shulyupin
[not found] ` <55982124.2070500@roeck-us.net>
2015-07-05 6:57 ` Jean Delvare [this message]
2015-07-05 13:00 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150705085727.23e25d08@endymion.delvare \
--to=jdelvare@suse.de \
--cc=const@MakeLinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=open@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®