From: Peter Zijlstra <peterz@infradead.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Stephane Eranian <eranian@google.com>,
mathieu.poirier@linaro.org, Pawel Moll <pawel.moll@arm.com>
Subject: Re: [RFC V2 PATCH 1/4] perf: Add PERF_RECORD_SWITCH to indicate context switches
Date: Mon, 6 Jul 2015 13:17:48 +0200 [thread overview]
Message-ID: <20150706111748.GB3644@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1435927962-32417-2-git-send-email-adrian.hunter@intel.com>
On Fri, Jul 03, 2015 at 03:52:39PM +0300, Adrian Hunter wrote:
> +static void perf_event_switch(struct task_struct *task,
> + struct task_struct *next_prev, bool out)
> +{
The patch looks good, however with perf_pmu_sched_task() we have bool
sched_in, and here we have bool out.
Maybe make that consistent?
next prev parent reply other threads:[~2015-07-06 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 12:52 [RFC V2 PATCH 0/4] " Adrian Hunter
2015-07-03 12:52 ` [RFC V2 PATCH 1/4] " Adrian Hunter
2015-07-06 11:17 ` Peter Zijlstra [this message]
2015-07-03 12:52 ` [RFC V2 PATCH 2/4] perf tools: Add new PERF_RECORD_SWITCH event Adrian Hunter
2015-07-03 12:52 ` [RFC V2 PATCH 3/4] perf record: Add option --switch-events to select PERF_RECORD_SWITCH events Adrian Hunter
2015-07-03 12:52 ` [RFC V2 PATCH 4/4] perf script: Add option --show-switch-events Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706111748.GB3644@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@kernel.org \
--cc=pawel.moll@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®