From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: david.vrabel@citrix.com, roger.pau@citrix.com,
elena.ufimtseva@oracle.com, stefano.stabellini@eu.citrix.com,
tim@xen.org, jbeulich@suse.com, andrew.cooper3@citrix.com,
ian.campbell@citrix.com, wei.liu2@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] xen/x86: Remove unnecessary memset() call
Date: Tue, 7 Jul 2015 15:27:46 -0400 [thread overview]
Message-ID: <20150707192746.GB6372@l.oracle.com> (raw)
In-Reply-To: <1436240065-10813-3-git-send-email-boris.ostrovsky@oracle.com>
On Mon, Jul 06, 2015 at 11:34:21PM -0400, Boris Ostrovsky wrote:
> Since ctxt is kzalloc'd there is no need to call a memset for
> ctxt->fpu_ctxt.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> arch/x86/xen/smp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
> index ca7ee1f..7cf0765 100644
> --- a/arch/x86/xen/smp.c
> +++ b/arch/x86/xen/smp.c
> @@ -377,7 +377,6 @@ cpu_initialize_context(unsigned int cpu, struct task_struct *idle)
> ctxt->user_regs.fs = __KERNEL_PERCPU;
> ctxt->user_regs.gs = __KERNEL_STACK_CANARY;
> #endif
> - memset(&ctxt->fpu_ctxt, 0, sizeof(ctxt->fpu_ctxt));
>
> if (!xen_feature(XENFEAT_auto_translated_physmap)) {
> ctxt->user_regs.eip = (unsigned long)cpu_bringup_and_idle;
> --
> 1.8.1.4
>
next prev parent reply other threads:[~2015-07-07 19:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 3:34 [PATCH 0/6] 32-bit PVH domU support Boris Ostrovsky
2015-07-07 3:34 ` [PATCH 1/6] xen/x86/pvh: Save %rbx in xen_pvh_early_cpu_init() Boris Ostrovsky
2015-07-07 20:16 ` Konrad Rzeszutek Wilk
2015-07-07 20:26 ` Konrad Rzeszutek Wilk
2015-07-07 20:51 ` Boris Ostrovsky
2015-07-07 20:49 ` Boris Ostrovsky
2015-07-07 3:34 ` [PATCH 2/6] xen/x86: Remove unnecessary memset() call Boris Ostrovsky
2015-07-07 19:27 ` Konrad Rzeszutek Wilk [this message]
2015-07-07 3:34 ` [PATCH 3/6] xen/x86/pvh: Properly set page tables for 32-bit PVH guests Boris Ostrovsky
2015-07-07 19:31 ` Konrad Rzeszutek Wilk
2015-07-07 3:34 ` [PATCH 4/6] xen/x86/pvh: Set up descriptors " Boris Ostrovsky
2015-07-07 19:54 ` Konrad Rzeszutek Wilk
2015-07-07 20:42 ` Boris Ostrovsky
2015-07-07 3:34 ` [PATCH 5/6] xen/x86/pvh: Add 32-bit PVH initialization code Boris Ostrovsky
2015-07-07 19:59 ` Konrad Rzeszutek Wilk
2015-07-07 20:33 ` Konrad Rzeszutek Wilk
2015-07-07 3:34 ` [PATCH 6/6] xen/x86/pvh: Allow building 32-bit PVH guests Boris Ostrovsky
2015-07-07 20:00 ` Konrad Rzeszutek Wilk
2015-07-08 12:50 ` [Xen-devel] [PATCH 0/6] 32-bit PVH domU support David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707192746.GB6372@l.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=elena.ufimtseva@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome