From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: david.vrabel@citrix.com, roger.pau@citrix.com,
elena.ufimtseva@oracle.com, stefano.stabellini@eu.citrix.com,
tim@xen.org, jbeulich@suse.com, andrew.cooper3@citrix.com,
ian.campbell@citrix.com, wei.liu2@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] xen/x86/pvh: Save %rbx in xen_pvh_early_cpu_init()
Date: Tue, 07 Jul 2015 16:51:42 -0400 [thread overview]
Message-ID: <559C3BDE.8090103@oracle.com> (raw)
In-Reply-To: <20150707202615.GH6372@l.oracle.com>
On 07/07/2015 04:26 PM, Konrad Rzeszutek Wilk wrote:
>>> diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
>>> index 8afdfcc..b1508a8 100644
>>> --- a/arch/x86/xen/xen-head.S
>>> +++ b/arch/x86/xen/xen-head.S
>>> @@ -56,28 +56,28 @@ ENTRY(startup_xen)
>>> * @entry: true if this is a secondary vcpu coming up on this entry
>>> * point, false if this is the boot CPU being initialized for
>>> * the first time (%rsi)
>>> - *
>>> - * Note: This is called as a function on the boot CPU, and is the entry point
>>> - * on the secondary CPU.
>>> */
>>> ENTRY(xen_pvh_early_cpu_init)
>>> - mov %rsi, %r11
>>> + mov %rbx, -8(%rsp)
>>>
>>> +/* Entry point for secondary CPUs */
> Actually, could you do this (since the BSP can access the stack and
> it can do jumps) - not compile tested:
Yes, this looks better, I'll try it. Thanks.
-boris
next prev parent reply other threads:[~2015-07-07 20:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 3:34 [PATCH 0/6] 32-bit PVH domU support Boris Ostrovsky
2015-07-07 3:34 ` [PATCH 1/6] xen/x86/pvh: Save %rbx in xen_pvh_early_cpu_init() Boris Ostrovsky
2015-07-07 20:16 ` Konrad Rzeszutek Wilk
2015-07-07 20:26 ` Konrad Rzeszutek Wilk
2015-07-07 20:51 ` Boris Ostrovsky [this message]
2015-07-07 20:49 ` Boris Ostrovsky
2015-07-07 3:34 ` [PATCH 2/6] xen/x86: Remove unnecessary memset() call Boris Ostrovsky
2015-07-07 19:27 ` Konrad Rzeszutek Wilk
2015-07-07 3:34 ` [PATCH 3/6] xen/x86/pvh: Properly set page tables for 32-bit PVH guests Boris Ostrovsky
2015-07-07 19:31 ` Konrad Rzeszutek Wilk
2015-07-07 3:34 ` [PATCH 4/6] xen/x86/pvh: Set up descriptors " Boris Ostrovsky
2015-07-07 19:54 ` Konrad Rzeszutek Wilk
2015-07-07 20:42 ` Boris Ostrovsky
2015-07-07 3:34 ` [PATCH 5/6] xen/x86/pvh: Add 32-bit PVH initialization code Boris Ostrovsky
2015-07-07 19:59 ` Konrad Rzeszutek Wilk
2015-07-07 20:33 ` Konrad Rzeszutek Wilk
2015-07-07 3:34 ` [PATCH 6/6] xen/x86/pvh: Allow building 32-bit PVH guests Boris Ostrovsky
2015-07-07 20:00 ` Konrad Rzeszutek Wilk
2015-07-08 12:50 ` [Xen-devel] [PATCH 0/6] 32-bit PVH domU support David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559C3BDE.8090103@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=elena.ufimtseva@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome