From: Markus Pargmann <mpa@pengutronix.de>
To: Hermann Lauer <Hermann.Lauer@iwr.uni-heidelberg.de>
Cc: nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, Michal Belczyk <belczyk@bsd.krakow.pl>
Subject: Re: [PATCH v4.0 for testing] nbd: Fix timeout detection
Date: Thu, 9 Jul 2015 15:21:20 +0200 [thread overview]
Message-ID: <20150709132120.GJ7573@pengutronix.de> (raw)
In-Reply-To: <20150709080651.GA25210@lemon.iwr.uni-heidelberg.de>
[-- Attachment #1: Type: text/plain, Size: 1760 bytes --]
Hi Hermann,
On Thu, Jul 09, 2015 at 10:06:52AM +0200, Hermann Lauer wrote:
> Hello Markus,
>
> > On Fri, Apr 24, 2015 at 09:35:33AM +0200, Markus Pargmann wrote:
> > > At the moment the nbd timeout just detects hanging tcp operations. This
> > > is not enough to detect a hanging or bad connection as expected of a
> > > timeout.
> > ...
> > > Cc: Michal Belczyk <belczyk@bsd.krakow.pl>
> > > Cc: Hermann Lauer <Hermann.Lauer@iwr.uni-heidelberg.de>
> > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> > > [mpa: Backported to 4.0]
> > >
> > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> > > ---
> > >
> > > This patch is only for testing at the moment. I will backport the final patch
> > > for the stable tree at the end.
> >
> > tested with 4.0 - timeout works as expected after
> > disconnecting the ethernet.
> > No hang or unexpected kernel message.
>
> still no problems so far - may I ask if the patch made his way upstream ?
> If you already submitted it, knowing the commit would be nice to tell
> it to the Debian maintainers.
Thanks for reporting. Sorry for the delay, but I queued the patch for
4.3 yesterday.
The patch will not go into the stable kernel trees. This is somehow more
of a feature than a bug. The timeout works as it was designed. This
patch just makes the timeout handling more intuitive for the user.
I hope this is fine for you.
Best regards,
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-07-09 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150423144313.GI19764@lemon.iwr.uni-heidelberg.de>
2015-04-24 7:35 ` Markus Pargmann
2015-04-24 14:41 ` Hermann Lauer
2015-07-09 8:06 ` Hermann Lauer
2015-07-09 13:21 ` Markus Pargmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709132120.GJ7573@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=Hermann.Lauer@iwr.uni-heidelberg.de \
--cc=belczyk@bsd.krakow.pl \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®