mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Craig Inches <craig.inches@xayto.net>
To: Joe Perches <joe@perches.com>
Cc: Craig <craig.inches@xayto.net>,
	gregkh@linuxfoundation.org, arve@android.com,
	riandrews@android.com, mitchelh@codeaurora.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: android: ion: Fix Style Issue
Date: Tue, 14 Jul 2015 09:36:37 +0000	[thread overview]
Message-ID: <20150714093637.GA15958@Morat.xayto.local> (raw)
In-Reply-To: <1436787742.2711.98.camel@perches.com>

On Mon, Jul 13, 2015 at 04:42:22AM -0700, Joe Perches wrote:
> On Mon, 2015-07-13 at 17:29 +0000, Craig wrote:
> > Modified style issue in ion.c. Missing empty line after a definition
> > 
> > Signed-off-by: Craig <craig.inches@xayto.net>
> > ---
> >  drivers/staging/android/ion/ion.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> > index 6f48112..e44f5e6 100644
> > --- a/drivers/staging/android/ion/ion.c
> > +++ b/drivers/staging/android/ion/ion.c
> > @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
> >  	struct ion_buffer *buffer;
> >  	struct dma_buf *dmabuf;
> >  	bool valid_handle;
> > +
> >  	DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
> >  
> >  	mutex_lock(&client->lock);
> 
> checkpatch false positive.
Thanks for the feed back.

> Fixed in checkpatch by
> https://lkml.org/lkml/2015/7/1/383
and the reference to the fix.

Cheers,
Craig 

  reply	other threads:[~2015-07-14  2:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13 17:29 Craig
2015-07-13 11:42 ` Joe Perches
2015-07-14  9:36   ` Craig Inches [this message]
2015-07-13 12:35 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150714093637.GA15958@Morat.xayto.local \
    --to=craig.inches@xayto.net \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitchelh@codeaurora.org \
    --cc=riandrews@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®