* [PATCH] devres: fix devres_get()
@ 2015-07-14 1:18 Masahiro Yamada
2015-07-14 19:01 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2015-07-14 1:18 UTC (permalink / raw)
To: Greg KH; +Cc: Tejun Heo, Masahiro Yamada, linux-kernel
Currently, devres_get() passes devres_free() the pointer to devres,
but devres_free() should be given with the pointer to resource data.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Fixes: commit 9ac7849e35f7 ("devres: device resource management")
---
drivers/base/devres.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/devres.c b/drivers/base/devres.c
index c8a53d1..8754646 100644
--- a/drivers/base/devres.c
+++ b/drivers/base/devres.c
@@ -297,10 +297,10 @@ void * devres_get(struct device *dev, void *new_res,
if (!dr) {
add_dr(dev, &new_dr->node);
dr = new_dr;
- new_dr = NULL;
+ new_res = NULL;
}
spin_unlock_irqrestore(&dev->devres_lock, flags);
- devres_free(new_dr);
+ devres_free(new_res);
return dr->data;
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] devres: fix devres_get()
2015-07-14 1:18 [PATCH] devres: fix devres_get() Masahiro Yamada
@ 2015-07-14 19:01 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2015-07-14 19:01 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Greg KH, linux-kernel
On Tue, Jul 14, 2015 at 10:18:29AM +0900, Masahiro Yamada wrote:
> Currently, devres_get() passes devres_free() the pointer to devres,
> but devres_free() should be given with the pointer to resource data.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Fixes: commit 9ac7849e35f7 ("devres: device resource management")
Please cc stable@vger.kernel.org.
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-14 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-14 1:18 [PATCH] devres: fix devres_get() Masahiro Yamada
2015-07-14 19:01 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®