mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH percpu/for-4.3] percpu: update incorrect comment for this_cpu_*() operations
@ 2015-06-26 21:21 Tejun Heo
  2015-07-14 21:45 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2015-06-26 21:21 UTC (permalink / raw)
  To: Christoph Lameter, linux-kernel, kernel-team

this_cpu_*() ops have been protected against both preemption and
interrupts for quite a while now.  We apparently forgot to update the
comment.  Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Christoph Lameter <cl@linux-foundation.org>
---
 include/linux/percpu-defs.h |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/include/linux/percpu-defs.h
+++ b/include/linux/percpu-defs.h
@@ -488,10 +488,8 @@ do {									\
 #define __this_cpu_dec_return(pcp)	__this_cpu_add_return(pcp, -1)
 
 /*
- * Operations with implied preemption protection.  These operations can be
- * used without worrying about preemption.  Note that interrupts may still
- * occur while an operation is in progress and if the interrupt modifies
- * the variable too then RMW actions may not be reliable.
+ * Operations with implied preemption/interrupt protection.  These
+ * operations can be used without worrying about preemption or interrupt.
  */
 #define this_cpu_read(pcp)		__pcpu_size_call_return(this_cpu_read_, pcp)
 #define this_cpu_write(pcp, val)	__pcpu_size_call(this_cpu_write_, pcp, val)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH percpu/for-4.3] percpu: update incorrect comment for this_cpu_*() operations
  2015-06-26 21:21 [PATCH percpu/for-4.3] percpu: update incorrect comment for this_cpu_*() operations Tejun Heo
@ 2015-07-14 21:45 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2015-07-14 21:45 UTC (permalink / raw)
  To: Christoph Lameter, linux-kernel, kernel-team

On Fri, Jun 26, 2015 at 05:21:28PM -0400, Tejun Heo wrote:
> this_cpu_*() ops have been protected against both preemption and
> interrupts for quite a while now.  We apparently forgot to update the
> comment.  Fix it.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Christoph Lameter <cl@linux-foundation.org>

Applied to percpu/for-4.3.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-14 21:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-26 21:21 [PATCH percpu/for-4.3] percpu: update incorrect comment for this_cpu_*() operations Tejun Heo
2015-07-14 21:45 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®