From: Mark Brown <broonie@kernel.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Fix memory leak in regulator_resolve_supply()
Date: Wed, 15 Jul 2015 16:52:54 +0100 [thread overview]
Message-ID: <20150715155254.GR11162@sirena.org.uk> (raw)
In-Reply-To: <55A65621.4080109@osg.samsung.com>
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
On Wed, Jul 15, 2015 at 02:46:25PM +0200, Javier Martinez Canillas wrote:
> On 07/15/2015 01:27 PM, Mark Brown wrote:
> > using _regulator_get() I think. A separate, rarely used, path is likely
> > to have this sort of issue.
> Exactly, do you agree then that a try_module_get() is missing in set_supply()?
> It is OK if I add that in the same patch in v2 or do you prefer that to be
> in a separate patch?
A separate patch would be better, or even better would be something that
just replaces everything there with use of the same code path as _get()
(thanks for volunteering!) but just adding the try_module_get() is fine
for now.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-15 15:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 14:21 Javier Martinez Canillas
2015-07-15 8:01 ` Krzysztof Kozlowski
2015-07-15 8:38 ` Javier Martinez Canillas
2015-07-15 11:27 ` Mark Brown
2015-07-15 12:46 ` Javier Martinez Canillas
2015-07-15 15:52 ` Mark Brown [this message]
2015-07-15 15:56 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715155254.GR11162@sirena.org.uk \
--to=broonie@kernel.org \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®